enabling Add CAPTCHA administration links to forms, adds captcha to all forms even custom search blocks for logged in user.

I understand that this is by design, but without the fieldset classed out, themers cannot hide this when it appears in areas of a theme it shouldn't. For example, any custom search block added to the header area of a theme, will automatically get this captcha option.. and to disable it, a themer must hide all fieldsets in that region.. if there were a class added to the fieldset, we could easily just hide that captcha fieldsets in whatever areas are undesirable.

I have attached an image which should illustrate the problem

CommentFileSizeAuthor
#3 captcha-admin-links.png74.35 KBKrisBulman
#2 1142606_captchaadminlinksclass.patch557 bytessoxofaan
captchaclass.jpg120.53 KBKrisBulman
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

KrisBulman’s picture

KrisBulman CreditAttribution: KrisBulman commented
Title: enabling Add CAPTCHA administration links to forms, adds captcha to all forms even custom search blocks » add a captcha class to the wrapping fieldset for 'place a captcha here'
soxofaan’s picture

soxofaan CreditAttribution: soxofaan commented
Title: add a captcha class to the wrapping fieldset for 'place a captcha here' » add a css class to the wrapping fieldset for 'place a captcha here'
Version: 6.x-2.4 » 6.x-2.x-dev
Issue tags: +low-hanging fruit
FileSize
1142606_captchaadminlinksclass.patch557 bytes

I haven't got the time to try it out, but the following should do the trick I suppose

KrisBulman’s picture

KrisBulman CreditAttribution: KrisBulman commented
Status: Active » Reviewed & tested by the community
FileSize
captcha-admin-links.png74.35 KB 
git status
# On branch 6.x-2.x
git apply -v 1142606_captchaadminlinksclass.patch Checking patch captcha.module...
Applied patch captcha.module cleanly.

captcha-admin-links class added to fieldset properly

soxofaan’s picture

soxofaan CreditAttribution: soxofaan commented
Status: Reviewed & tested by the community » Closed (fixed)

committed (on 6.x-2.x and 7.x-1.x): http://drupalcode.org/project/captcha.git/commit/616f033, http://drupalcode.org/project/captcha.git/commit/a46272a

thanks for testing