Overview

#3550350: Ability to pan around canvas editor by holding SPACE + drag added feature related to SPACE in Canvas, due to which Space stopped working in Canvas AI while adding prompt.

Proposed resolution

User interface changes

Issue fork canvas-3558947

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

narendrar created an issue. See original summary.

jessebaker’s picture

jessebaker commented
Assigned: Unassigned » jessebaker

jessebaker opened merge request !341

jessebaker’s picture

jessebaker commented
Assigned: jessebaker » Unassigned
Status: Active » Needs review

The recent hotkey addition in [##3550350] to track the spacebar being pressed did indeed introduce an issue here.

It seems that useHotkeys will automatically detect if the user is focused into a form element or contenteditable but because is using shadowDom it doesn't recognise when the user is focused into the AI chat input. The event target is instead the element and not the contenteditable div inside it.

narendrar’s picture

narendrar
He/Him
Primary language English
Location Jaipur, India
commented
Status: Needs review » Reviewed & tested by the community

Tested and it works as expected, Thanks.

  • tedbow committed 11b5f5ae on 1.x authored by jessebaker 
    feat: #3558947 Canvas AI: Adding SPACE in prompt not working

By: @...
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented

@jessebaker I recognise you efforts!🙇‍♂️

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.