#3531000: Show progress when executing prompts added agent polling. This is a follow-up for #43.2 to decide on what do do in case of showing agent message and final message which could be duplicate.
The orchestrator message and status currently always appear at the top, while the sub-agent responses appear at the bottom. This creates a poor user experience. For example, the page builder agent may complete its task and display a message such as “components have been added,” but unless the orchestrator response is received, the components are not actually placed on the page. In this situation, the user may need to scroll up to notice the “thinking” status indicating that the orchestrator is still running. This results in a confusing and suboptimal experience. To improve this, the orchestrator response should be moved to the bottom.
The duplication of messages mentioned in #43.2 was caused by two reasons:
buildHtmlContent method in Aiwizard compiles messages from all agents obtained through polling, which also includes the orchestrator message. Once polling is complete, the orchestrator message should be removed from the list so that only the sub-agent messages are displayed.
[ ] AI Assisted Issue
This issue was generated with AI assistance, but was reviewed and refined by the creator.
[ ] AI Assisted Code
This code was mainly generated by a human, with AI autocompleting or parts AI generated, but under full human supervision.
[x] AI Generated Code
This code was mainly generated by an AI with human guidance, and reviewed, tested, and refined by a human.
[ ] Vibe Coded
This code was generated by an AI and has only been functionally tested.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | Drupal Canvas (2).gif | 2.65 MB | akhil babu |
| #6 | Drupal Canvas (1).gif | 1.77 MB | akhil babu |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
akhil babuComment #3
akhil babuComment #5
akhil babuComment #6
akhil babuComment #7
akhil babuComment #8
akhil babuIn this demo, once the component is placed, an error appears in the Canvas UI:
Your latest change was not saved because the content was modified elsewhere since you loaded the page. Please refresh your browser to receive the latest changes and continue.
This occurs intermittently. I have created a follow-up issue #3571988: Canvas AI: Error when placing components to track this separately.
Comment #9
akhil babuComment #10
akhil babuComment #11
akhil babuComment #12
scott falconer commentedReviewed MR !550 (https://git.drupalcode.org/project/canvas/-/merge_requests/550)
Code review notes:
- BE: CanvasBuilder now always uses the orchestrator agent's solve() output for the final user-visible message, instead of sometimes taking a tool wrapper's readable output.
- FE: AiWizard removes the orchestrator status item before composing the final "history" message so it doesn't appear twice. While polling, the orchestrator status is moved to the end of the list so it stays at the bottom.
Functional testing (local DDEV):
- Create/open a Canvas page in the editor.
- Open the Drupal Canvas AI panel.
- Run an AI action (e.g. Generate metadata / "Generate a description for this page").
- Confirm the orchestrator polling message is shown at the bottom while running, and the final orchestrator message is only shown once (no duplicate final message from a sub-agent + orchestrator).
Tests/lint run:
- ddev phpcs modules/canvas_ai/src/Controller/CanvasBuilder.php (pass; PHPCS deprecation warning only)
- ddev phpunit modules/canvas_ai/tests/src/Kernel/Plugin/AiFunctionCall/CreateComponentTest.php (pass; PHPUnit deprecations)
- ddev phpunit modules/canvas_ai/tests/src/Kernel/Plugin/AiFunctionCall/EditComponentJsTest.php (pass; PHPUnit deprecations)
- ddev exec --dir=/var/www/html/ui npm test -- --testTimeout 15000 (pass)
Notes (unrelated, but observed while testing on origin/1.x):
- ddev phpunit modules/canvas_ai/tests/src/Kernel/Plugin/AiFunctionCall/GetNodeFieldsTest.php currently errors: missing ai_agent:get_node_fields plugin.
- ddev exec --dir=/var/www/html/ui npm run type-check currently fails with TS2322 in ui/src/components/aiExtension/AiWizard.tsx for DeepChat ButtonPosition ('inside-start').
Based on the above, I think MR !550 is ready to move to Reviewed.
AI disclosure: I used an AI assistant for code review support, browser-driven functional testing, and to help summarize the results.
Comment #14
narendrarComment #16
akhil babuLinking a related issue from AI agents module, which also triggers duplicate final messages
Comment #17
akhil babu