Problem/Motivation

campaign_kit/modules/campaign_kit_core/src/Form/TeamRevisionRevertForm.php:60: $container->get('entity.manager')->getStorage('team'),
campaign_kit/modules/campaign_kit_core/src/Form/CampaignTransactionRevisionRevertTranslationForm.php:54: $container->get('entity.manager')->getStorage('campaign_transaction'),
campaign_kit/modules/campaign_kit_core/src/Form/DonationRevisionDeleteForm.php:69: $entity_manager = $container->get('entity.manager');
campaign_kit/modules/campaign_kit_core/src/Form/DonationRevisionRevertForm.php:60: $container->get('entity.manager')->getStorage('donation'),
campaign_kit/modules/campaign_kit_core/src/Form/TeamRevisionRevertTranslationForm.php:54: $container->get('entity.manager')->getStorage('team'),
campaign_kit/modules/campaign_kit_core/src/Form/DonationRevisionRevertTranslationForm.php:54: $container->get('entity.manager')->getStorage('donation'),
campaign_kit/modules/campaign_kit_core/src/Form/CampaignTransactionRevisionRevertForm.php:60: $container->get('entity.manager')->getStorage('campaign_transaction'),
campaign_kit/modules/campaign_kit_core/src/Form/CampaignUpdateRevisionRevertTranslationForm.php:54: $container->get('entity.manager')->getStorage('campaign_update'),
campaign_kit/modules/campaign_kit_core/src/Form/CampaignUpdateRevisionRevertForm.php:60: $container->get('entity.manager')->getStorage('campaign_update'),
campaign_kit/modules/campaign_kit_core/src/Form/CampaignRevisionRevertForm.php:60: $container->get('entity.manager')->getStorage('campaign'),
campaign_kit/modules/campaign_kit_core/src/Form/CampaignUpdateRevisionDeleteForm.php:69: $entity_manager = $container->get('entity.manager');
campaign_kit/modules/campaign_kit_core/src/Form/CampaignRevisionRevertTranslationForm.php:54: $container->get('entity.manager')->getStorage('campaign'),
campaign_kit/modules/campaign_kit_core/src/Form/TeamRevisionDeleteForm.php:69: $entity_manager = $container->get('entity.manager');
campaign_kit/modules/campaign_kit_core/src/Form/CampaignRevisionDeleteForm.php:69: $entity_manager = $container->get('entity.manager');
campaign_kit/modules/campaign_kit_core/src/Form/CampaignTransactionRevisionDeleteForm.php:69: $entity_manager = $container->get('entity.manager');

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 campaign_kit-replaced-entity-manager-with-entity-type-manager-3281785-2.patch10.97 KB_shy

Comments

SocialNicheGuru created an issue. See original summary.

_shy’s picture

_shy
Primary language Ukrainian
Location Ukraine, Lutsk 🇺🇦
commented
Status: Active » Needs review
StatusFileSize
new campaign_kit-replaced-entity-manager-with-entity-type-manager-3281785-2.patch10.97 KB

Here is a patch where replaced entity.manager with the entity_type.manager service.

socialnicheguru’s picture

socialnicheguru commented

I am wondering if this has to also be placed at the top of the various files in order to access entity_type.manager

use Drupal\Core\Entity\EntityTypeManagerInterface;

_shy’s picture

_shy
Primary language Ukrainian
Location Ukraine, Lutsk 🇺🇦
commented

SocialNicheGuru, no, it's unnecessary.
Because entity_type.manager it's just id of the service that injected to the class.