If you follow the this link and try and press previous you can't get to February 2018

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Purencool created an issue. See original summary.

StryKaizer’s picture

Status: Active » Needs review

The problem seems to be that in pagination 1 month is added/substracted, instead of using next/previous month, which causes issues when the current day of the month is 31

Patch attached

StryKaizer’s picture

Purencool’s picture

FileSize
396.54 KB
97.88 KB

I have applied the patch and it did not work. I think there is a larger issue, I have attached an image that displays the problem. When the URLs are changed to February manually returns a 404. Attached is a zipped copy of the module with the applied patch.

Purencool’s picture

This is a Drupal core issue with namespacing see https://www.drupal.org/project/drupal/issues/2913957 if you apply the patch the issue will go away

StryKaizer’s picture

I experienced a 404 at first too, but this went away after updating calendar.
@Purencool are you using the latest version of calendar while testing the patch?

Purencool’s picture

@strykaizer yes, you are correct the website had three bugs.
1. The Namespacing bug in Drupal core in comment #5.
2. The dev version of this module (It was not the latest)
3. The patch in this issue.

It was the perfect storm =)

Status: Needs review » Needs work

The last submitted patch, 3: 2940522--calendar-misses-february.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.