Calendar module needs to be converted to use short array syntax as per new coding standard.

CommentFileSizeAuthor
#3 calender_array_search_results.png112.87 KBdhruveshdtripathi
#2 short_array_syntax-2875548-2.patch17.03 KBMunavijayalakshmi
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Munavijayalakshmi created an issue. See original summary.

Munavijayalakshmi’s picture

Munavijayalakshmi CreditAttribution: Munavijayalakshmi at Valuebound commented
Assigned: Munavijayalakshmi » Unassigned
Status: Active » Needs review
FileSize
short_array_syntax-2875548-2.patch17.03 KB
dhruveshdtripathi’s picture

dhruveshdtripathi CreditAttribution: dhruveshdtripathi at DevsAdda commented
Status: Needs review » Reviewed & tested by the community
FileSize
calender_array_search_results.png112.87 KB

Patch applied cleanly. All the arrays converted to short array syntax. Checked it manually. As you can see in the attached png file, earlier there were 60 array declarations, after applying patch there are 14. Those 14 arrays are is_array and in_array.

Good work!

benelori’s picture

benelori CreditAttribution: benelori commented

I can confirm that the patch does its job.

I don't know if there is a test bot for this module, so I think it's ok to leave the issue status on RTBC.

geertvd credited geertvd.

geertvd’s picture

geertvd CreditAttribution: geertvd at Geert van Dort commented
Status: Reviewed & tested by the community » Fixed

Had to do a quick reroll but thanks for the work on this!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.