Tab navigation doesn't work when you've used the pagers

Calendar View Date Arguments cause Page not found when argument string is longer than format expects:

i.e.
argument = 20170523 (Ymd)
validation_format = 'Ym'

Either in link generation (view tabs) or in argument validation, we need to alter the argument value to match the expected validation format.

YW format already tries to do something like this:

FROM DateArgumentWrapper.php

  protected function createFromFormat($value) {
    $format = $this->getArgFormat();
    if ($format == 'YW') {
      $date = new \DateTime();
      $year = (int)substr($value, 0, 4);
      $month = (int)substr($value, 4, 2);
      $date->setISODate($year, $month);
    }
    else {
      // Adds a ! character to the format so that the date is reset instead of
      // using the current day info, which can lead to issues for months with
      // 31 days.
      $format = '!' . $this->getArgFormat();
      $date =  \DateTime::createFromFormat($format, $value);
    }
    return $date;
  }

I will continue to work on this and provide a patch as soon as I can.

Just started tracing the issue.

I put some kint statements in createFromFormat to see what it is doing.

It appears to take the date format from the current view display, rather than trying to determine the type of display that the tab would be for.

This is an obvious statement, but it may be tricky to try to obtain the correct formats out of the view, since the tabs at that point consist only of a path and a string (i.e. "Month" - which could be translated as well).

The following is a work-around, since it is overriding the tabs instead of re-architecting how the calendar module creates them in the first place. The code deals with url params (i.e. form options) as well. In a production environment, this should probably be refactored into a set of helper functions.

/**
 * Implements hook_menu_local_tasks_alter().
 * Ensure that the date portion of the tab url is in the correct format.
 */
function YOUR_MODULE_menu_local_tasks_alter(&$data, $route_name) {
  // Needs to be set to the specific calendar view's machine id.
  $view_name = 'view.VIEW_NAME';

  // Needs to be set to the default type of display (i.e. day / week / month / year)
  $default_display = 'month';

  if (strpos($route_name, $view_name) !== FALSE) {
    // Work out what display we're currently on.
    $route_name_find = $view_name . '.page_';
    $route_name_temp = str_replace($route_name_find, '', $route_name);
    
    // If default, we still need to parse out the dates.
    if ($route_name_temp == '') {
      $route_name_temp = $default_display; 
    }
    
    // Check to see if a query string exists
    $current_uri = \Drupal::request()->getRequestUri();
    $uri_parts = explode('?', $current_uri);
    
    // If a query string exists, set it as an option on the pager links.
    if (isset($uri_parts[1])) {
      // Get the query into an array.
      $query = urldecode($uri_parts[1]);
      parse_str($query, $query_parts);

      // Clean up array params.
      foreach ($query_parts as $index => $query_part) {
        // If we are dealing with a "multiple" option.
        if (is_array($query_part)) {
          // Save it temporarily.
          $temp_key = $index;
          $temp_part = $query_part;

          // Remove it from the index of query items.
          unset($query_parts[$index]);

          // Create separate keyed items in our param array for each
          // of the "multiple" options.
          $key_parts = explode('[', $temp_key);
          foreach ($temp_part as $temp_index => $temp_item) {
            $new_key = $key_parts[0] . '[' . $temp_index . ']';
            $query_parts[$new_key] = $temp_item;
          }
        }
      }

      $query_keys = array_keys($query_parts);
      $query_values = array_values($query_parts);
    }
  
 
    // Process the tabs.
    $tabs = $data['tabs'][0];
    foreach ($tabs as $tab_name => $tab) {
      // Try to figure out what type of tab it is.
      $tab_name_find = 'views_view:' . $view_name . '.page_';
      $tab_name_temp = str_replace($tab_name_find, '', $tab_name);
      $link = $tab['#link'];
      $url = $link['url'];
      $params = $url->getRouteParameters();
      $date_param = $params['arg_0'];

      if (!is_null($date_param)) {
        // Try to turn the param into an actual date.
        $new_date = 0;
        if ($route_name_temp == 'day') {
          // format is yyyymmdd
          $year = substr($date_param, 0, 4);
          $month = substr($date_param, 4, 2);
          $day = substr($date_param, 6, 2);
          $new_date = mktime(0, 0, 0, $month, $day, $year);
        }
        else if ($route_name_temp == 'week') {
          // format is yyyyww
          $year = substr($date_param, 0, 4);
          $week = substr($date_param, 4, 2);
          $new_date = strtotime("01 Jan " . $year . " 00:00:00 GMT + " . $week . " weeks");
        }
        else if ($route_name_temp == 'month') {
          // format is yyyymm
          $year = substr($date_param, 0, 4);
          $month = substr($date_param, 4, 2);
          $day = 1;
          $new_date = mktime(0, 0, 0, $month, $day, $year);
        }      
        else if ($route_name_temp == 'year') {
          // format is yyyy 
          $year = substr($date_param, 0, 4);
          $month = 1;
          $day = 1;
          $new_date = mktime(0, 0, 0, $month, $day, $year);
        }

        // Now figure out what sort of date format we need for the tab.
        if ($new_date != 0) {
          if ($tab_name_temp == 'day') {
            $new_date = date('Ymd', $new_date);
          }
          else if ($tab_name_temp == 'week') {
            $new_date = date('YW', $new_date);
          }
          else if ($tab_name_temp == 'month') {
            $new_date = date('Ym', $new_date);
          }
          else if ($tab_name_temp == 'year') {
            $new_date = date('Y', $new_date);
          }
          
          // Push the param back in.
          $data['tabs'][0][$tab_name]['#link']['url']->setRouteParameter('arg_0', $new_date);
          
          // Put any query params back in as well.
          if (!empty($query_parts)) {
            $data['tabs'][0][$tab_name]['#link']['url']->setOption('query', $query_parts);
          }
        }
      }
    }
  }
}

Hi,
I think this issue is fixed with attached patch.
Inactive tabs now have clean paths without incorrect dates after using pagers.
I don't know if is the best approach but it works for me.

Straight re-roll of #5.

The patch from #7 applied cleanly and works but it has some problems with coding standards. I applied the patch and fix coding standard errors and created a new patch. See interdiff for details. Marking this as "Needs review".

fixed coding standard errors.

Patch needs reroll

Re-rolled patch please review.

Here's an updated patch.

After applying #18 patch, tabs were working fine, but there are some another issues for Year Calendar.
To reproduce that apply #18 patch and click on Year tab

1. 1. First issue you will see is "Website Encountered Error."
2. 2. Once you fix first issue then you will see theme is completely broken for Year calendar

This patch fixes all of these issues.
Test with Drupal 9.4 and Calendar 8.x-1.0-alpha4 version

I reroled the patch from #19, it was breaking the style and it had warning error when you visit the year view of the calendar. Test with Drupal 9.4 and Calendar 8.x-1.0-alpha4 version.

Issues should target dev. Test the patch with dev, not just alpha

Here is a patch against 8.x-1.x-dev for testing.

Patch #23 fixed it for me. It works by altering the local tasks and removing extra arguments from the path. Maybe we should check in the css changes separately if those aren't necessary for this.

Updated patch so it applies to beta2.

Thanks for keeping this up-to-date, I would agree with you that the CSS stuff needs to be moved to a separate fix if it's needed.
Issue summary could explain this better

I see no mention of CSS issue in the summary nor in the patch, which does the job! Thank you! +3

There is still CSS code in the patches. This still needs work.

2867991-tab_navigation_fix branch is going back to the fix from #5.

With just this, the date contextual arguments are stripped from the other tabs so they are not broken.