I created a "year" view. It shows a large table with all of the days in the year, but month names are not rendered (see attached image).

Would it not make more sense for a "year" view to be a set of 12 month mini-calendars, each with its own heading?

CommentFileSizeAuthor
#10 2756445-month-names-not-showing-10.patch3.9 KBjazzfiction
Screen Shot 2016-06-27 at 11.01.24 AM.png269.05 KBjeremylichtman
#3 month-names-not-showing-2756445.patch1.19 KBjeremylichtman
#6 Screen Shot 2017-11-24 at 12.01.18.png56.58 KBmaaty388
#6 Screen Shot 2017-11-24 at 11.59.55.png23.83 KBmaaty388
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jeremylichtman created an issue. See original summary.

fourmi4x’s picture

fourmi4x CreditAttribution: fourmi4x commented

Hi, I agree this is a must-have, the Year display is not really usable otherwise (we can't see to which month a day is corresponding)

jeremylichtman’s picture

jeremylichtman CreditAttribution: jeremylichtman for Cheeky Monkey Media commented
FileSize
month-names-not-showing-2756445.patch1.19 KB

Attached patch passes the month names through to the mini-calendar month template.

jeremylichtman’s picture

jeremylichtman CreditAttribution: jeremylichtman for Cheeky Monkey Media commented
jeremylichtman’s picture

jeremylichtman CreditAttribution: jeremylichtman for Cheeky Monkey Media commented
Assigned: Unassigned » jeremylichtman
maaty388’s picture

maaty388 CreditAttribution: maaty388 commented
FileSize
Screen Shot 2017-11-24 at 11.59.55.png23.83 KB
Screen Shot 2017-11-24 at 12.01.18.png56.58 KB

That looks much better

maaty388’s picture

maaty388 CreditAttribution: maaty388 commented
manuga’s picture

manuga CreditAttribution: manuga at Diputació de Barcelona commented

Hello, I've tried patch # 3 and it works, thanks

manuga’s picture

manuga CreditAttribution: manuga at Diputació de Barcelona commented

The month names are not translatable
I think something like
$vars['options']['month_name'] = t(date($month_format, mktime(0, 0, 0, $month, 10)));
will resolve the problem.

jazzfiction’s picture

jazzfiction CreditAttribution: jazzfiction as a volunteer commented
FileSize
2756445-month-names-not-showing-10.patch3.9 KB

This works for me also.

I created a new patch against the current version and included the translation suggestion in #9. I also separated the setting of the month name abbreviations from the day name abbreviation setting into it's own setting.

nkoporec’s picture

nkoporec
Primary language English
Location Slovenia
CreditAttribution: nkoporec as a volunteer commented

Tried the latest patch and it works.

nkoporec’s picture

nkoporec
Primary language English
Location Slovenia
CreditAttribution: nkoporec as a volunteer commented
Status: Active » Reviewed & tested by the community

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Reviewed & tested by the community » Fixed

This seems to work nicely, so I went ahead and pushed it to 8.x-1.x. Thanks!

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Issue tags: +DevDaysLisbon

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.