Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#12 | calendar-change_datetime_dependency-2741259-12.patch | 346 bytes | szeidler |
#5 | composer-json-2741259-5.patch | 667 bytes | Shreya Shetty |
#3 | composer-json-2741259-3.patch | 540 bytes | widukind |
#2 | composer-json-2741259-2.patch | 459 bytes | Shreya Shetty |
Comments
Comment #2
Shreya Shetty CreditAttribution: Shreya Shetty as a volunteer and commentedComment #3
widukind CreditAttribution: widukind as a volunteer commentedLGTM overall. FWIW, I added the keywords and support.source attributes.
Comment #4
Anonymous (not verified) CreditAttribution: Anonymous at XIO commentedThanks for the patch!
The composer.json file also needs to list dependencies, like views_templates, no?
Comment #5
Shreya Shetty CreditAttribution: Shreya Shetty as a volunteer and commentedYes we should ..Thank You for the review . I have made the changes
Comment #7
Anonymous (not verified) CreditAttribution: Anonymous at XIO commentedAlright, thank you!
Committed and pushed to 8.x-1.x.
Comment #8
sukanya.ramakrishnan CreditAttribution: sukanya.ramakrishnan commentedHmm, getting errors with downloading the module.
Should the requirement for drupal/calendar_datetime be there? it is a submodule of this module right?
Comment #9
sukanya.ramakrishnan CreditAttribution: sukanya.ramakrishnan commentedUpdate, i had to remove the requirement for drupal/calendar_datetime to make this work.
Thanks
Sukanya
Comment #10
miscellainiac CreditAttribution: miscellainiac commentedSame here. Although in my case, I replaced the requirement for drupal/calendar_datetime to just drupal/datetime. Can we get this issue re-opened and looked at? At the very least, it would be nice to know which one is actually required, if either of them actually are.
I can confirm that this is happening with Drupal 8.1.6; I haven't tried yet with a previous version of core.
Comment #11
miscellainiac CreditAttribution: miscellainiac commentedComment #12
szeidler CreditAttribution: szeidler at Ramsalt Lab commentedAt the moment, the composer.json is breaking the composer workflow, because of missing package information for the calendar_datetime submodule.
For me it seems, as the submodule is not a real requirement anymore for the base calendar module anymore, but the Drupal Core datetime module is.
For that reason the composer requirement should be changed.
Comment #13
chris.smith CreditAttribution: chris.smith at Portage CyberTech commentedI can confirm that the patch in #12 solves the issue in #8.
Comment #15
Anonymous (not verified) CreditAttribution: Anonymous at XIO commentedSeems like a reasonable thing to do. Thanks all!