Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Follow-up to #2604514: Work on dateViewFields()
Problem/Motivation
Follow-up from #2600416: Fix date_views_fields() call in row plugin preRender().
We added a function dateViewFields() in CalendarHelper, which figures out what the view fields are that can contain datetime information. It's a quick port from the date_view_fields() function that was available in the date_view module.
Improve the row plugin render function.
Proposed resolution
Fix as much as possible.
Remaining tasks
Do it.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | Screen Shot 2015-10-30 at 20.50.35.png | 77.27 KB | Anonymous (not verified) |
| #4 | interdiff-3-4.txt | 2.1 KB | Anonymous (not verified) |
| #4 | improve_the_row_render-2604516-4.patch | 4.79 KB | Anonymous (not verified) |
| #3 | 2604516.patch | 2.68 KB | Anonymous (not verified) |
Comments
Comment #1
Anonymous (not verified) CreditAttribution: Anonymous at XIO commentedpjonckiere created an issue. See original summary.
Comment #2
Anonymous (not verified) CreditAttribution: Anonymous at XIO commentedComment #3
Anonymous (not verified) CreditAttribution: Anonymous at XIO commentedHere is some initial work. It works as expected and removes the hardcoded values we had. We probably want to improve on it before we get it in though.
Comment #4
Anonymous (not verified) CreditAttribution: Anonymous at XIO commentedI did some scope creep to demonstrate that the patch in #3 makes sense.
Comment #6
Anonymous (not verified) CreditAttribution: Anonymous at XIO commentedI pushed these changes. Let's do the rest in follow-up tickets with a more specific scope.