We could be using README.md instead of README.txt to make use of the nicer rendering via markdown.

Now that we've moved to GitLab, we should probably use Markdown instead of plain .txt files for our documentation

CommentFileSizeAuthor
#12 after.png301.02 KBkenyoowen
#12 before.png302.23 KBkenyoowen
#9 3321130-9.patch3.55 KBnitin_lama

Issue fork cacheflush-3321130

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nitapawar created an issue. See original summary.

nitapawar opened merge request !1

nitapawar’s picture

nitapawar commented
Status: Active » Needs review

Committed according to proposed solution!
Please review!

Nila Hyalij’s picture

Nila Hyalij commented
Status: Needs review » Reviewed & tested by the community

Reviewed the README.md, The Markdown looks good to me, Adhering to Drupal markdown practices.

Changing status to Reviewed and Tested by Community.

vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
commented
Assigned: nitapawar » Unassigned
vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
commented
Version: 8.x-1.x-dev » 2.0.x-dev
vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

Please update the MR to the latest 2.0.x branch. Thank you.

nitin_lama’s picture

nitin_lama
he/him
Location India
commented
Assigned: Unassigned » nitin_lama
nitin_lama’s picture

nitin_lama
he/him
Location India
commented
StatusFileSize
new 3321130-9.patch3.55 KB

Providing patch for 2.0.x

nitin_lama’s picture

nitin_lama
he/him
Location India
commented
Status: Needs work » Needs review

Please review.

nitin_lama’s picture

nitin_lama
he/him
Location India
commented
Assigned: nitin_lama » Unassigned
kenyoowen’s picture

kenyoowen commented
Priority: Normal » Minor
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new before.png302.23 KB
new after.png301.02 KB

Hi nitin_lama

I tested your patch#9 and reviewed your changes and confirmed it follows the README.md template. . Please look at the screenshots attached for your reference.

Thank you.

  • vuil committed f53799bd on 2.0.x 
    Issue #3321130 by nitapawar, vuil, nitin_lama, kenyoowen, Nila Hyalij:...
vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed. I close the issue as Fixed.

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.