We have a business rule that sends out an email when a node is created. When creating a node using JSONAPI the token replacements cause a HTTP 500 error due to the leaked metadata.

Patch forthcoming.

CommentFileSizeAuthor
#12 business_rules-tokens_cause_leaked_metadata-3042236-12.patch2.31 KBdaften
#11 business_rules-tokens_cause_leaked_metadata-3042236-11.patch2.31 KBdaften
#8 business_rules-tokens_cause_leaked_metadata-3042236-8.patch2.76 KBcolan
#8 interdiff-3042236-2-8.diff2.2 KBcolan
#2 business_rules-tokens_cause_leaked_metadata-3042236-2.patch2.18 KBmatthijs

Comments

Matthijs created an issue. See original summary.

matthijs’s picture

matthijs
Primary language Dutch
commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new business_rules-tokens_cause_leaked_metadata-3042236-2.patch2.18 KB

There might be a better fix, but this one works in our case.

matthijs’s picture

matthijs
Primary language Dutch
commented
Title: Token replacements lead to leaked meta data » Token replacements lead to leaked metadata
c.e.a’s picture

c.e.a commented
Priority: Normal » Major

This issue has been added to #3041221: List of all 'Bug reports' that need immediate support Assigned to: yseki

c.e.a’s picture

c.e.a commented
Assigned: Unassigned » yseki
c.e.a’s picture

c.e.a commented
Assigned: yseki » Unassigned
Status: Needs review » Patch (to be ported)
c.e.a’s picture

c.e.a commented
Status: Patch (to be ported) » Reviewed & tested by the community
colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new interdiff-3042236-2-8.diff2.2 KB
new business_rules-tokens_cause_leaked_metadata-3042236-8.patch2.76 KB

How's this?

  • Removed duplicate code.
  • Placed object instantiation in-line.
colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented
Status: Needs review » Postponed (maintainer needs more info)

Is this related to #3064744: Possible memory leak on adding Conditions screen?

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented
Issue tags: +Performance
daften’s picture

daften commented
StatusFileSize
new business_rules-tokens_cause_leaked_metadata-3042236-11.patch2.31 KB

Rerolled patch for 3.x

The problem is in certain situations, e.g. when sending out email, there was an error as the title described: `The controller result claims to be providing relevant cache metadata, but leaked metadata was detected. Ensure you are not rendering content too early`

daften’s picture

daften commented
StatusFileSize
new business_rules-tokens_cause_leaked_metadata-3042236-12.patch2.31 KB

With working patch now

rcodina’s picture

rcodina
Primary language Catalan
Location Barcelona
commented
Version: 8.x-1.x-dev » 3.x-dev
rcodina’s picture

rcodina
Primary language Catalan
Location Barcelona
commented
Status: Postponed (maintainer needs more info) » Needs review