Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
After the recent core update to DRUPAL 8.4.2 the slideshow no longer displays on the homepage despite the selection being made in the theme configuration.
Comment | File | Size | Author |
---|---|---|---|
#10 | custom.js_.patch | 374 bytes | bmatthewshea |
#9 | custom.js_.patch | 159 bytes | bmatthewshea |
#3 | slider.png | 114.38 KB | verhoevc |
Comments
Comment #2
tibezh CreditAttribution: tibezh at OPTASY, Drupal Ukraine Community commentedHi @verhoevc, I've tested a slideshow on homepage in the Drupal 8.4.2 and 8.4.3, I don't have any problems.
Can you provide more details please. Did you look at developer console?
Comment #3
verhoevc CreditAttribution: verhoevc commentedThis is what I'm seeing.
Comment #4
verhoevc CreditAttribution: verhoevc commentedComment #5
verhoevc CreditAttribution: verhoevc commentedComment #6
kncrabtree CreditAttribution: kncrabtree commentedI am having the same issue on version 8.x-1.7 of the theme, and I believe this is related to the jQuery version change from 8.3->8.4. In my production site (8.3.x), the slideshow works properly with jQuery2, but my development site broke upon updating to 8.4.x and jQuery3.
There is an uncaught typeError "a.indexOf is not a function" that triggers on:
This code needs to use the .on('load',...) method to work in jQuery3.
Comment #7
crispiatico CreditAttribution: crispiatico as a volunteer commentedI have the same problem :-(
Theme Business 8.x-1.7 (
Drupal 8.4.5
Comment #8
Anks CreditAttribution: Anks as a volunteer commentedYes, there is an issue with the jquery code.
As kncrabtree suggested need to replace the code of custom.js with following.
This will resolve the issue.
Thanks,
Ankit
Comment #9
bmatthewshea CreditAttribution: bmatthewshea commented(delete this)
Comment #10
bmatthewshea CreditAttribution: bmatthewshea commentedPlease patch your code. It's 1 line to fix slider under 8.x.x.
The problem is you are trying to use a deprecated load from newer jquery. Console will tell you it cannot load them as-is:
Comment #11
bmatthewshea CreditAttribution: bmatthewshea commentedComment #12
Vojta CreditAttribution: Vojta commentedSame problem with Drupal 8.6.15, the suggested fix works well.
Comment #13
apadernoComment #14
BhumikaVarshney CreditAttribution: BhumikaVarshney as a volunteer and at OpenSense Labs commentedYes, the above suggestion works good for me.
Comment #15
arborrow CreditAttribution: arborrow commentedI agree that the patch worked for me as well. Kindly update the package.
Comment #16
Gauravvvv CreditAttribution: Gauravvvv at OpenSense Labs for Drupal India Association commentedThis patch doesn't work anymore
Comment #17
Gauravvvv CreditAttribution: Gauravvvv at OpenSense Labs for Drupal India Association commentedComment #18
apadernoThe patch needs to be created from the directory containing the module. From that directory, the custom.js file is in js/custom.js.
Comment #19
apadernoFurthermore, the content of the custom.js file is the following.
The code has been fixed in commit 84cdd33, as result of #2920983: Slideshow disappeared out of nowhere, created on November 4, 2017. This issue is a duplicate of that issue.