While working on #2311787: Notice: Undefined index: ismobiledevice in browscap_ctools_browscap_access_ctools_access_check I noted excessive permissions on source files.

Module source normally should not have eXecutable Linux flag, attached patch corrects this.

CommentFileSizeAuthor
#3 remove-executable-flag-from-sources-fixed.patch852 bytesmillionleaves
remove-executable-flag-from-sources.patch368 bytesdpovshed
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dpovshed created an issue. See original summary.

hamrant’s picture

hamrant CreditAttribution: hamrant at DEWEB Studio for Drupal Ukraine Community commented
Status: Needs review » Reviewed & tested by the community

good fix

millionleaves’s picture

millionleaves CreditAttribution: millionleaves as a volunteer and commented
FileSize
remove-executable-flag-from-sources-fixed.patch852 bytes

This patch broke my site due to this error in line 10 (use of isarry instead of is_array)

+ if (isarry($browser) && array_key_exists('ismobiledevice',$browser) &&

should be the following:

+ if (is_array($browser) && array_key_exists('ismobiledevice',$browser) &&

New patch attached.

dpovshed’s picture

dpovshed CreditAttribution: dpovshed as a volunteer and at Drupal Ukraine Community commented

@millionleaves I believe your patch should be addressed to the issue #2311787: Notice: Undefined index: ismobiledevice in browscap_ctools_browscap_access_ctools_access_check, to the patch in comment #8 by Thomas.

In this thread I just fixing the file permissions - that's all :)