->isNotNull('playlist_id)
should be used instead of
->condition('playlist_id', TRUE, 'IS NOT NULL')

@see Drupal\Core\Database\Query\Condition::isNotNull

CommentFileSizeAuthor
#2 3109216-brightcove-1.x-fix_isNotNull_condition-2.patch1.6 KBbohart

Comments

bohart created an issue. See original summary.

bohart’s picture

bohart
Location Lutsk, Ukraine
commented
Status: Active » Needs review
Issue tags: +LutskGCW20
StatusFileSize
new 3109216-brightcove-1.x-fix_isNotNull_condition-2.patch1.6 KB

Here is a patch for both 8.x-1.x / 8.x-2.x versions.

yce’s picture

yce commented
Priority: Normal » Minor
bohart’s picture

bohart
Location Lutsk, Ukraine
commented

Please be aware: this patch fixing fatal errors in some cases.

->condition('playlist_id', TRUE, 'IS NOT NULL') it doesn't play well with all databases / database drivers.

One of the cases is on the referenced issue.

Thanks!

  • 2fd02c1 committed on 8.x-2.x 
    Issue #3109216 by bohart: Fatal error: isNotNull should be used instead...
yce’s picture

yce commented
Status: Needs review » Fixed

Thanks, the patch is now applied.

bohart’s picture

bohart
Location Lutsk, Ukraine
commented

Hi @yce,
thanks for committing the patch!

ps. btw, please be aware of `Author` attribution under `Credit & committing` section while committing any further patches. Thanks!
https://www.drupal.org/node/1146430

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.