Problem/Motivation

The dark theme option causes white text on white background when utilized with CKEditor 5. See - https://www.drupal.org/project/layout_builder_blocks/issues/3346996#comm...

In addition the size of the Ckeditor text field is too short when source mode is used but I'm not sure this is caused by this module.

Steps to reproduce

Enable Layout Builder Modal - Bootstrap Styles and Layout Builder Blocks - create a content block in Drupal 10 and choose a CKeditor5 as the text format and type in the text area and it will be white on white. This causes issues with tables as well.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

robbt created an issue. See original summary.

majmunbog’s picture

Status: Active » Needs review
StatusFileSize
new353 bytes

Here's a quick patch to fix the white text on the white background issue in CKEditor.

majmunbog’s picture

StatusFileSize
new335 bytes

The wrong patch, this one is much better.

robbt’s picture

Also noticed that the dark.css line 665 #layout-builder-modal textarea,
- height: auto; causes the textarea to shrink to only 78px tall when viewing source with CKEditor 5 so I'll try to submit a patch to fix this as well.

rajab natshah’s picture

Status: Needs review » Needs work

Thanks, for reporting and patching!

While you are making the above changes, we recommend that you convert this patch to a merge request. Merge requests are preferred over patches. Be sure to hide the old patch files as well.

Redwan Jamous made their first commit to this issue’s fork.

redwan jamous’s picture

Status: Needs work » Needs review
StatusFileSize
new1.48 KB

Created a MR...
Attaching a patch file to use with composer...