Problem/Motivation

Editors can upload big images or no web-optimized.

Adding a option to select a Image Style will be more flexible for editors.

Steps to reproduce

Proposed resolution

If we want this to be optional, add a checbox and then a select with all Image Styles availables, this could be done per plugin instance, not global settting.

Update buildBackgroundMediaImage funciton to create image url using the Image style selected.
This could help: https://gist.github.com/slivorezka/925dff0369e8eddc7e4ffa4801ab0240

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#14 3167538-14.patch5.12 KBsardis
#12 3167538-12.patch5.4 KBmauriciopieper

Issue fork bootstrap_styles-3167538

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

edysmp created an issue. See original summary.

aaronchristian’s picture

aaronchristian commented

This is a much needed enhancement!

Love your thinking @edysmp

nitesh624’s picture

nitesh624
he/him
Primary language English
Location Ranchi, India
commented

Working on it will update in few days

nitesh624’s picture

nitesh624
he/him
Primary language English
Location Ranchi, India
commented
Assigned: Unassigned » nitesh624
nitesh624’s picture

nitesh624
he/him
Primary language English
Location Ranchi, India
commented

Unassigning from me , so that others can also work

nitesh624’s picture

nitesh624
he/him
Primary language English
Location Ranchi, India
commented
Assigned: nitesh624 » Unassigned
edysmp’s picture

edysmp
Primary language Spanish
Location Nicaragua
commented
Issue summary: View changes
mahmoud-zayed’s picture

mahmoud-zayed commented
Status: Active » Needs work

matt_paz made their first commit to this issue’s fork.

matt_paz opened merge request !38

matt_paz’s picture

matt_paz commented
Status: Needs work » Needs review
mauriciopieper’s picture

mauriciopieper commented
StatusFileSize
new 3167538-12.patch5.4 KB

Created this patch based on the merge request from @matt_paz.
I did some small changes/improvements because it was an old MR, but in essence, it does the same.

b_sharpe’s picture

b_sharpe commented
Status: Needs review » Needs work

This need to be passing the interface FileUrlGeneratorInterface otherwise you'll have issues with other file generators.

sardis’s picture

sardis commented
Status: Needs work » Needs review
StatusFileSize
new 3167538-14.patch5.12 KB

@b_sharpe is right indeed. Such an error can be reproduced should you enable CDN module.

Attached is an updated patch that uses FileUrlGeneratorInterface instead of FileUrlGenerator.

rajab natshah’s picture

rajab natshah
he/him
commented
Status: Needs review » Needs work

Thanks, for reporting and patching!

While you are making the above changes, we recommend that you convert this patch to a merge request. Merge requests are preferred over patches. Be sure to hide the old patch files as well.

rajab natshah’s picture

rajab natshah
he/him
commented
Status: Needs work » Fixed
Issue tags: +bootstrap_styles-1.1.6, +bootstrap_styles-2.0.0-alpha1
rajab natshah’s picture

rajab natshah
he/him
commented
rajab natshah’s picture

rajab natshah
he/him
commented
Status: Fixed » Needs work
Issue tags: -bootstrap_styles-1.1.6, -bootstrap_styles-2.0.0-alpha1
rajab natshah’s picture

rajab natshah
he/him
commented

Nice idea and fix
Planed for #3299909: Fix Layout Builder section rendering original Background Image when no background options, no image styles, or lazy loading are applied
But seems that this is a good way to fix the issue.

super_romeo’s picture

super_romeo commented

Thanks for the patches #12 and #14. They are on the right track.
But I think we need to set the responsive image style, not the image style.