Needs review
Project:
Bootstrap 5 - SASS Starter Kit
Version:
5.0.10
Component:
Code
Priority:
Normal
Category:
Support request
Assigned:
Unassigned
Reporter:
Created:
12 Jan 2024 at 13:21 UTC
Updated:
2 Apr 2024 at 05:41 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
hatuhay commentedComment #3
tommyk commentedThe files in the
js/directory, includingjs/bootstrap.min.js, have not been recompiled as minimum required versions for the theme have increased. Notice that the version ofjs/bootstrap.min.jscomes from the initial commit over 6 years ago.While it is understood that these files will be overwritten when we compile assets for our own subthemes, I think it makes sense to keep them up-to-date for released versions of the theme. I encountered the same issue when installing this theme just to try it out without the extra work of creating a customized version of it.
If you aren't willing to keep the compiled assets up to date then putting a notice of some kind in the documentation or on the project page would be helpful. Something like
would clarify the situation quite a bit.
(The original issue I came looking for is that the dropdown menus in the Admin Toolbar do not work on the frontend when this theme is in use out of the box.)
Comment #4
ravi kant commented@TommyK
Are you creating a sub-theme of bootstrap_sass?
I did not find an issue when I ran the gulp command on the bootstrap_sass folder and, I got the 'bootstrap.min.js' version according to bootstrap_sass version.
Comment #5
tommyk commented> Are you creating a sub-theme of bootstrap_sass?
No, I am not. I stated that in my comment.
> While it is understood that these files will be overwritten when we compile assets for our own subthemes, I think it makes sense to keep them up-to-date for released versions of the theme. I encountered the same issue when installing this theme just to try it out without the extra work of creating a customized version of it.
Comment #6
ravi kant commentedOk @TommyK
I am agree that default compile style files should be upto date with latest compile.
Comment #8
ravi kant commentedI have created MR !18 for compiled styles files.