Closed (fixed)
Project:
Bootstrap Paragraphs
Version:
8.x-2.x-dev
Component:
Code
Priority:
Minor
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
6 Feb 2023 at 03:21 UTC
Updated:
7 Oct 2024 at 10:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
sahil.goyal commentedFixing the phpcs warnings, attaching the patch, please review.
Comment #3
sahil.goyal commentedComment #5
charchil khandelwal commentedI will review this.
Comment #7
charchil khandelwal commentedPatch #2 tested and applied successfully, all the errors and warnings are fixed.
Created MR !4 for easy preview and commenting.
RTBC +1.
Thanks.
Comment #8
paraderojether commentedHi Charchil Khandelwal
I reviewed MR!4, and verified it fixes all the issue reported by phpcs. Drupal core version 9.5.8, Bootstrap Paragraphs 8.x-2.x-dev.
I added screenshots for reference.
Thank You.
Comment #9
avpadernoComment #10
avpadernoThose are not Drupal core modules.
Comment #11
ashutosh ahirwal commentedProviding patch with solution.
please review.
Comment #12
avpadernoThe space after the colon must be removed.
Comment #15
avpadernoThose are not Drupal core modules.
Comment #16
paraderojether commentedComment #17
avpadernoIf those are not Drupal core modules,
drupal:cannot be used to refer to those modules. The dependencies format is [project name]:[module name], where [project name] is replaced by the machine name of the project that contains the module, and [module name] is the module machine name.Comment #18
Devon_4224 commentedWorking on this for Drupalcon 2023 Pittsburgh
Comment #19
nitin_lamaComment #20
nitin_lamaComment #21
nitin_lamaComment #22
nikolay shapovalov commentedPlease check MR.
Hide patch files, let's continue with MR workflow.
Comment #23
avpadernoComment #24
a.aaronjake commentedHi @everyone,
Applied and reviewed MR!4, on my terminal, errors were still reported. Please see below:
Kindly check
Thanks,
Jake
Comment #25
avpadernoComment #27
thejimbirch commentedMerged to dev, thanks all.