I have added support for some init BS4 layout classes, the patch below adds:
1. There are no longer xs breakpoint at BS4 (it's now col-#), I renamed the label to "Extra Small (BS3)"
2. New breakpoint has been added Extra large (xl): Added new section "Extra large"
3. BS4 Auto-layout columns: added under new section Auto-layout columns (BS4) see more https://v4-alpha.getbootstrap.com/layout/grid/#auto-layout-columns
List of classes that has been added can be found at this screenshot: https://www.screencast.com/t/yQwGdCQg46pL
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | bootstrap_layouts-n2863131-11.patch | 2.79 KB | damienmckenna |
| #11 | bootstrap_layouts-n2863131-11.interdiff.txt | 1.48 KB | damienmckenna |
Comments
Comment #2
samerali commentedComment #3
samerali commentedComment #4
samerali commentedComment #5
samerali commentedComment #6
markhalliwellConsidering that BS4 is still just in alpha, I'm going to take the same stance I have in the base theme: we'll wait for an official RC.
Also, muddying settings with labels (to denote BS3 vs BS4) is likely not the direction we want to go.
Instead, I would imagine https://www.drupal.org/project/bootstrap_core should really be implemented to provide a "global version" setting.
It should also probably have an API to deal with finding templates and classes based on the version selected.
This would allow us to provide a much cleaner UI/UX.
Comment #7
markhalliwellConsidering that BS4 adds even more "grid classes" than before and a ton of "utility classes", I really think this parent issue should be implemented before we even begin to think about BS4.
Otherwise, we run the risk of making customizing these layouts even more complicated and select elements unmanageably longer than they already are.
Thus, I'm officially postponing this issue on that one.
Comment #8
samerali commentedTotally agree on this, the select element is mostly unusable i was thinking to add chosen to it so it's auto complete. but what i just saw on #2834675 sounds like future proof plan
Comment #9
keha3912 commentedBootstrap 4 beta
Comment #10
theruslanAny plans to merge patch #2 into dev?
Comment #11
damienmckennaThe indentation is incorrect on a portion of the patch.
Comment #12
markhalliwellSetting status back to postponed as stated in #7.
No, I don't have any plans on committing the current patches approach as is.
To further explain why this is postponed on #7, combining both BS3 and BS4 options in the same dropdown is extremely bad UI/UX.
Not only from a consumer standpoint but also from a developer standpoint (it's likely just going to create greater confusion more than anything).
The reality is that both BS3 and BS4 have a lot of similar naming conventions. While similar, in both subtle and not so subtle ways, they're effectively two different frameworks.
As I have mentioned in the Drupal Bootstrap IQ a few times, we need a "global version" (i.e. a select element that allows you to choose BS3, BS4, BS5, etc.) setting somewhere that will allow bootstrap related code to choose the appropriate major framework it works off of.
Comment #13
skaughtindeed, combining generations of BS would be a large amount of support from one module.
https://www.drupal.org/project/bootstrap_five_layouts. I'm forking for this reason. cheers.