Upgrading a couple sites to 4.29.0 and I get the WSOD with this message:
TypeError: Argument 1 passed to Drupal\Core\Render\Element::children() must be of the type array, null given, called in /app/web/core/modules/layout_discovery/layout_discovery.module on line 44 in /app/web/core/lib/Drupal/Core/Render/Element.php on line 71 #0 /app/web/core/modules/layout_discovery/layout_discovery.module(44)
All of these sites have layout builder enabled. Reverting to Barrio 4.28.0 fixes the issue.
Comments
Comment #2
hatuhay commentedI need more information as I cannot reproduce.
If not using Display Suite, please try v5.0.0-beta1, it is almost the same as 4.29.0 but with no DS based layouts
Comment #3
jurgenhaasI'm seeing the same issue. At the same time, no images are output in the HTML anymore. When I remove the bootstrap_barrio.layouts.yml file, then the page renders without WSOD but the images are still missing.
Going back to 4.28, images are showing again, that OK.
Going to 5.x is not possible, because I also use bootstrap_sass which requires bootstrap_barrio 4.x and so dependency doesn't allow me to test the 5.x branch.
Comment #4
jurgenhaasThe missing media entities being displayed is caused by the new file
themes/contrib/bootstrap_barrio/layouts/media.html.twigwhich is recognized by the theming layer and being used to render media entities. But as that file is intended to be used as a layout and not as a theme template, it doesn't contain the necessary variables to output the required content.Comment #5
technotim2010 commentedSame issue found this morning,
Resolved in this thread on drupal slack
https://drupal.slack.com/archives/C1BMUQ9U6/p1592468314341600
Should help maintainers fix the issue.
Regards
Tim
Comment #6
yahyaalhamadCan confirm, same here.
Comment #8
hatuhay commentedPlease confirm on new dev version before pushing as stable...
Comment #11
hatuhay commentedComment #12
hatuhay commentedComment #13
basseye commentedHi. I don't think the media issue is fixed as yet. Just updated to Barrio 4.30 and all images on my website have disappeared. Thanks
Comment #14
hatuhay commented@basseye
Please provide with error message or any other extra information.
The original error, I was able to reproduce with the data provided and was fixed changing the name of the layout file.
Comment #15
technotim2010 commentedI have discovered the same effect, all images and even oembed on media in pages using layout discovery disappeared.
I spent all evening fixing it (having spent all morning working, with members of the Community including core devs on finding out the problem that was causing the issue.
This definitely needs fixing. The damage to this site is already done, I have downgraded to 4.28 and reimported saved config to no avail, testing on dev with little content sadly did not reveal the issue.
Good Night.
Tim
Comment #16
hatuhay commentedAnnotation made regarding the origin of this error:
https://www.drupal.org/node/2865188/revisions/view/11870475/11951299
Comment #17
basseye commented@hatuhay
Hope you're well. Unfortunately there is no error messages outputted to indicate the source of the problem. I have reverted my site back to version 4.28, which is ok. So I think there is something seriously wrong with 4.30. Thanks.
Comment #18
hatuhay commentedI am not able to reproduce this error, so I am blind on this.
The community is important solving this issue.
If someone on private could provide with a site to test the error I can dive on it.
Reverting (not deleting) key parts of the theme separetly could help to narrow the scope:
Comment #19
hatuhay commentedComment #20
technotim2010 commentedI have copies of the db and contrib modules from when I upgraded to 4.29 yesterday, unfortunately I will not be upgrading to 4.30 until this is resolved. I too have downgraded to 4.28.
I have sent you an email.
Regards
Tim
Comment #21
hatuhay commentedTested on @TechnoTim2010 and Barrio 4.30 solved the original issue.
Still unable to reproduce #13 on Barrio 4.30.
If someone could provide example site, will help to debug this.
Comment #22
basseye commentedHi @TechnoTim2010, I wonder if your issue with the Barrio theme has been resolved. I've found that even after reverting to 4.28 and clearing my catch, the images have disappeared again, and it's not showing any error on inspection. I wonder if this problem is really to do with the core media module? is anyone else experiencing the same problem? I should add that I'm using paragraph with the paragraph grid module on my site. And oh, I'm also using the current Drupal 8.9.1. A feedback will be appreciated. Thanks
Comment #23
basseye commentedJust an update to my previous comment. I wonder if there is any more update on this issue. I've tested my site with different other themes, and everything seems to be working ok (media showing and all), so I'm ruling out other modules including core media as I mentioned earlier, as source of the problem. This issue seems persistent with the Barrio theme, and I wondered if anyone else is continuing to have the same problem of missing media with the Barrio theme? Thanks
Comment #24
hatuhay commented@basseye
The only thing I found was the conflict with the layout media name.
Name was changed, so the reference to it and the original issue was solved.
The difference between 4.28 and 4-29 are just small bugs and the new layouts, that really belong to 5.0.x, but as a transition were commited also to 4.29.
My suggestion is to test your site with 4.30 or better with 5.0.0-beta2 but taking this in consideration Upgrade to Bootstrap 5
For the hugh error you are describing, more reports should be seen here.
I you wish to share your code with me I can help you debug.