The bootstrap_barrio_preprocess_html function is stripping out $variables['attributes']['class'] variables even though they exist [#3032435]

The bootstrap_barrio_preprocess_html function is stripping out $variables['attributes']['class'] variables even though they exist in some cases.
I think this is happening when the $variables['attributes']['class'] is an object containing an array instead of an array itself. This is causing problems for me specifically with the imce module file browser page where the imce-page class is getting stripped out which prevents the javascript from loading. I fixed this locally by replacing the !is_array || !array_key_exists with the more generic !isset. Seems to work fine now. Is there any reason not to use !isset instead?
https://www.drupal.org/project/bootstrap_barrio/issues/3031270

Comment	File	Size	Author
#8	3032435-8.patch	450 bytes	weynhamz
#6	bootstrap_barrio_preprocess_html_fix.patch	478 bytes	cqbent
#3	3032435-remove-code-delete-body-class.patch	602 bytes	guaneagler

Comments

Comment #1

12 February 2019 at 16:50

cqbent created an issue. See original summary.

Comment #2

hatuhay commented 25 February 2019 at 02:09

Issue summary:	View changes
Status:	Active	» Needs review
Related issues:		+#3031270: Undefined index: class in bootstrap_barrio_preprocess_html()

The code was updated with this issue.
Undefined index: class in bootstrap_barrio_preprocess_html() (3031270)
If you can confirm your solution and provide a patch I will me more than happy to commit

Comment #3

guaneagler commented 25 February 2019 at 12:01

Status	File	Size
new	3032435-remove-code-delete-body-class.patch	602 bytes

Just remove the code this patch added.
For the $variables['attributes'], it may be an array or a object of 'Drupal\Core\Template\Attribute'. Both can set class by access $variables['attributes']['class'].
For my site, $variables['attributes'] is an array when is not logged in and is an object when is logged in.