Problem/Motivation

Views provides a lot of CSS for the views UI that needs to be removed if we want to style views UI like bootstrap.

Proposed resolution

Find out how to best remove the CSS.

Remaining tasks

Create patch.

User interface changes

Views will look more like bootstrap

API changes

None

Data model changes

None

CommentFileSizeAuthor
#4 2828855-override-views-4.patch59.36 KBtkoleary
#3 2828855-override-views-1.patch58.75 KBtkoleary
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tkoleary created an issue. See original summary.

tkoleary’s picture

tkoleary CreditAttribution: tkoleary at Acquia commented
Assigned: Unassigned » tkoleary

I've done some initial work on this. First I attempted to use libraries override to remove views ui css but was unsucessful.

Then after looking at the views CSS it occurred to me that perhaps that was not the best approach and I should copy the views css and selectively override only the parts of views that were creating problems. This has the advantage of making sure we are using the same selectors.

tkoleary’s picture

tkoleary CreditAttribution: tkoleary at Acquia commented
FileSize
2828855-override-views-1.patch58.75 KB

This patch also removes the bootstrap framework files and the compiled css.

tkoleary’s picture

tkoleary CreditAttribution: tkoleary at Acquia commented
FileSize
2828855-override-views-4.patch59.36 KB

Re-rolled #3 on top of patch #7 from [#11786797]

markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell at Tag1 Consulting commented
Status: Active » Postponed (maintainer needs more info)

Why is this duplicating the efforts in #2828158: Build 8.x version as a bootstrap sub-theme?

tkoleary’s picture

tkoleary CreditAttribution: tkoleary at Acquia commented

It's not so much duplicating the efforts, I just rolled on top of the other patch because otherwise there's nothing there, and it seemed to make sense for this to be a separate issue since it's specific to views.

I can move it all in to the other patch if you think that's a better approach.

markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell at Tag1 Consulting commented
Category: Task » Feature request
Status: Postponed (maintainer needs more info) » Postponed

Ok.. it just doesn't make a whole lot of sense to have two issues/patches doing the same work (even if this one just adds on top of the other).

I'd say let's keep this issue/code entirely separate from the other. Since this already has that issue assigned as the parent, leaving as postponed/blocked until that gets in.

tkoleary’s picture

tkoleary CreditAttribution: tkoleary at Acquia commented

Ok, sound good.