https://localize.drupal.org/translate/languages/de/translate?sid=2735434
https://localize.drupal.org/translate/languages/de/translate?sid=2735435

The mallfomed HTML filter permitts rendering strings with <div></div> Tags in it. Please make sure to remove the div from the strings on localize.drupal.org. Otherwise theses Srings will never get any trainslation in any language.-

CommentFileSizeAuthor
#9 interdiff_5-9.txt2.37 KBanagomes
#9 3157044-9.patch2.46 KBanagomes
#6 after-patch.png49.97 KBbhumikavarshney
#5 3157044-5.bootstrap.Remove-div-from-translation-strings.patch2.43 KBtobiasb

Issue fork bootstrap-3157044

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Joachim Namyslo created an issue. See original summary.

joachim namyslo’s picture

joachim namyslo
Primary language German
Location Kulmbach 🇩🇪 🇪🇺
commented
Title: Remove <div> from localisazion strings » Remove <div> from translation strings
joachim namyslo’s picture

joachim namyslo
Primary language German
Location Kulmbach 🇩🇪 🇪🇺
commented
Issue tags: +localization
joachim namyslo’s picture

joachim namyslo
Primary language German
Location Kulmbach 🇩🇪 🇪🇺
commented
Parent issue: #3041086: Bootstrap » #3157707: Prevent strings unsafe for translation in code
tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented
Status: Active » Needs review
StatusFileSize
new 3157044-5.bootstrap.Remove-div-from-translation-strings.patch2.43 KB

I change the div with the p element and also adds the default css classes for a warning.

bhumikavarshney’s picture

bhumikavarshney commented
StatusFileSize
new after-patch.png49.97 KB

Hi @tobiasb,
Patch applies cleanly and works fine for me.
Thanks!

markhalliwell’s picture

markhalliwell
Primary language English
commented
Title: Remove <div> from translation strings » Change <div> tags to <span> tags in translation strings
Status: Needs review » Needs work

I'd rather not use <p> tags as those tend to have extra margins associated with them and also semantically inaccurate. Let's use <span> tags instead.

Also, this should probably change any translation in the code that has these, not just this one.

anagomes’s picture

anagomes commented
Assigned: Unassigned » anagomes
anagomes’s picture

anagomes commented
Assigned: anagomes » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 3157044-9.patch2.46 KB
new interdiff_5-9.txt2.37 KB

Here's a patch with the <span> tags instead of <p>. Also providing an interdiff to help in the review.

WagnerMelo’s picture

WagnerMelo commented
Status: Needs review » Reviewed & tested by the community

Hello, i reviewed this issue and the @anagomes patch, and everything look like ok, i installed and run the theme in my environment and its works correctly.

kunal_sahu made their first commit to this issue’s fork.

kunal_sahu opened merge request !25

kunal_sahu’s picture

kunal_sahu commented

I have created an MR , please merge. Thanks

shelane’s picture

shelane
Primary language English
commented
Status: Reviewed & tested by the community » Closed (won't fix)

This theme will not be supported for Bootstrap 4. See alternative themes for this support.