Syntax error in attributes.js for Internet Explorer 11 [#2946791]

After updating the attributes.js changes from issue https://www.drupal.org/project/bootstrap/issues/2831237 we started to experience JS errors for Internet Explorer 11.

Error is Syntax error in regular expression.

Offending line is: identifier = identifier.replace(/[^\u002D\u0030-\u0039\u0041-\u005A\u005F\u0061-\u007A\u00A1-\uFFFF]/u, '', identifier);

Comment	File	Size	Author
#8	2946791-7.patch	940 bytes	markhalliwell
#8

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

22 February 2018 at 09:23

HeikkiY created an issue. See original summary.

Comment #2

markhalliwell

English

CreditAttribution: markhalliwell at Tag1 Consulting commented 22 February 2018 at 09:32

Version:	8.x-4.x-dev	» 8.x-3.x-dev
Priority:	Critical	» Minor

Who uses IE anymore?

I’ll leave this open to fix tomorrow, but seriously... use Edge or any other modern browser. IE is DEAD.

I’m having serious doubts of continuing any further IE support for this project.

Comment #3

HeikkiY CreditAttribution: HeikkiY commented 22 February 2018 at 09:37

Clients.

Comment #4

markhalliwell

English

CreditAttribution: markhalliwell at Tag1 Consulting commented 22 February 2018 at 09:44

I’m sorry, but thats really not a valid answer anymore. Nor was I really asking. It was a rhetorical “question” to show utter disbelief that anyone would still use an archaic browser.

It isn’t the “clients” fault that developers still support this browser instead of just telling them to upgrade in the first place to solve the “issue”.

Comment #5

HeikkiY CreditAttribution: HeikkiY commented 22 February 2018 at 09:48

We upgraded to the latest Bootstrap this morning and got a bug report from client in about 10 minutes that our site was broken in Internet Explorer 11. Unfortunately it is the fact that many corporate users are still using Internet Explorer as the default browser and in many cases users aren't allowed to change the default browser or use other browser.

Comment #6

lbodiguel CreditAttribution: lbodiguel commented 22 February 2018 at 15:42

Having the same issue with a customer that's still using IE11 :( Not a big deal for now, but what if there's a SA one day ? We should stop using this module and rebuild our themes ?

Comment #7

22 February 2018 at 17:05

markcarver committed 698af8d on 8.x-3.x

Issue #2946791 by markcarver: Syntax error in attributes.js for Internet...

Comment #8

markhalliwell

English

CreditAttribution: markhalliwell at Tag1 Consulting commented 22 February 2018 at 17:15

Status:

Active

» Fixed

File	Size
2946791-7.patch	940 bytes

Unfortunately it is the fact that many corporate users are still using Internet Explorer as the default browser and in many cases users aren't allowed to change the default browser or use other browser.

Then that is the fault of IT department of the corporation/organization. Again, this is merely a symptom of people catering to this severely outdated browser instead of just replacing them in the first place. It isn't that it "can't be done" it's that the IT depts are usually just lazy and don't want or care enough to replace it with something more modern.

what if there's a SA one day ?

This has nothing to do with a potential SA.

We should stop using this module and rebuild our themes ?

This project is base theme, not a module...

---

Since it isn't (yet) the official policy of this project to drop IE support, I have gone ahead and fixed this annoyance.

That being said, the 8.x-4.x branch (BS3/BS4) will not officially support IE at all. Despite what core and the external Bootstrap Framework's policies are regarding IE, I do not support condone the idea of continuing to support an antiquated browser that can easily be replaced with a modern one.

If you need IE support, you'll have to remain on 8.x-3.x (BS3).