Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.For a node edit form, the actions are converted into a dropdown menu and then preprocessed by bootstrap.
There appears to be a bug in the release of 3.8 that prevents dropdown submit buttons from being clickable, what I've narrowed it down to is this commit:
http://cgit.drupalcode.org/bootstrap/commit/?id=315fdb5
From what I can tell so far, with this change:
- $items->$key->element = $child->addClass('hidden')->getArrayCopy();
+ $element = $child->addClass('hidden')->getArrayCopy();
$element is the last referenced element of the foreach previously run:
foreach ($variables->links as &$element) {
So it seems to be overriding, in this case, the actual submit element which then doesn't show up in the HTML. It's supposed to be hidden, and then the dropdown code is supposed to trigger it, which is why it's just unclickable.
I don't have a patch yet because I want to understand the full context of the intended change, but I thought I'd share where I got so far.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | 2938198-7.patch | 2.02 KB | markhalliwell |
Comments
Comment #2
asherry CreditAttribution: asherry commentedComment #3
asherry CreditAttribution: asherry commentedOk I think the issue is that the code here:
...is actually overriding the original element which previously was getting populated as $items->$key->element. I have two patches that work for me though I admit I have not tested the actual translation functionality that this was originally intended to fix. That should definitely be done as well.
If this change works, I included two versions, 1 is if you revert the original commit and post a new commit, and the other patch is if you just want to make a fix commit.
Comment #4
markhalliwellI think I accidentally overlooked this when I was stepping through because of #2068063: Change "Save and keep un-/published" buttons to a "Published" checkbox and an included "Save" button.
I had to install https://www.drupal.org/project/publishing_dropbutton which adds the dropbuttons back to the node add/edit forms and allowed me to step through this again.
This patch should fix the problem. If it does, let me know and I'll commit and release because this is a pretty major break (unfortunately).
Comment #5
asherry CreditAttribution: asherry commentedYeah we have the publishing_dropbutton module installed, so that makes sense.
This patch seems to work now, I imagine you also can delete the code on line 142:
because you're re-setting the $child variable into a new element anyway. That was confusing me a bit.
Thanks so much for looking at that, and especially so fast. Either way I'll mark this as RTBC.
Comment #6
asherry CreditAttribution: asherry at Aten Design Group commentedComment #7
markhalliwellActually, no that's also a bug :D That logic is still needed, but should be done before the original element is added to the items list.