#2609316: Port Bootstrap to Drupal 8 brought many of these advancements into this project, namely in the form of our Plugin System. This is actually the core functionality of this project in Drupal 8, but most of it has absolutely nothing to with Bootstrap itself.

Comments

markcarver created an issue. See original summary.

markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell at Tag1 Consulting commented
Assigned: Unassigned » markhalliwell
Issue summary: View changes
Status: Postponed » Needs work
Parent issue: #474684: Allow themes to declare dependencies on modules »
Related issues: +#474684: Allow themes to declare dependencies on modules

I'm actually actively working on this in a private repo, so setting status to CNW. Will publish the module and close this issue once that is done.

I don't think it's wise to postpone on the core issue anymore though. It may make it in 8.6.0 (this fall), but it's not guaranteed to make it in 8.5.x at all now since it's technically a "feature" request.

As it stands now, we'll simply add it to the list of requirements (as we did with jQuery Update in 7.x).

markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell at Tag1 Consulting commented

The module that this stuff is going into is located here:

https://www.drupal.org/project/plus

Once #2947809: [Drupal+] Create a stable release is done, I will close this issue.

wundo’s picture

wundo CreditAttribution: wundo at Chuva Inc. for Chuva Inc. commented

Hi Mark,
I think that module needs a better description, what exactly you want that module to do? :)

markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell at Tag1 Consulting commented

It’ll have a better description once it’s completed. It’s still a WIP.

For now, you can watch https://cgit.drupalcode.org/plus/tree/README.md?h=8.x-4.x as I’m keeping a list of what it “does”.

truls1502’s picture

truls1502
he/him
Primary language Norwegian Bokmål
CreditAttribution: truls1502 as a volunteer and at SignWo AS commented

Hi Markcarver,

Do you mind to enlighten me about what Drupal+ can help Bootstrap 4, and what kind help do you need from us to help you to solve the issues at Drupal+ to able to use/get started with Bootstrap 4? I would like to help you, and want, of course, help you first with the issues at the bottom before we can contribute Bootstrap 4.

Thank you in advance! :)

temkin’s picture

temkin CreditAttribution: temkin at SiteCraft commented

I've just read through this comment that explains why Drupal+ is a dependency for Bootstrap 4. And although it makes perfect sense to "kill 2 birds with one stone", I'm afraid that we are adding more dependencies and constraints that may further postpone support of Bootstrap 4.

With all the respect to a project maintainer and his reasoning, I'd suggest to remove that issue as a dependency for Bootstrap 4 switch. We don't have to have it, it's more nice to have IMO. If there is good progress on Drupal+ side and it's ready in the very near future, then we can always move all the additional features out of Bootstrap theme and into Drupal+. Until then, it seems we are adding a blocker that's hard to overcome.

Please let me know if you think otherwise.

wundo’s picture

wundo CreditAttribution: wundo at Chuva Inc. for Chuva Inc. commented

I've just read @temkin's comment and I've to say I agree with it.

I have to be honest and confess I don't like having yet another dependency on my Drupal projects. My impression is that altough looks like a good idea in the short term will end up slowing the pace of the Bootstrap project in the long run.

Since I've last contributed in this patch I did spend quite sometime working with 8.x-3.x plugins and classes and my impression is that some of them have some over-engineering.

Also when I went to look at the Drupal+ readme again today I've noticed it says:
> This module keeps major version parity with core. For example, if you're using Drupal 8.4.x, then use releases from the 8.x-4.x branch. If using Drupal 8.5.x, then use releases from the 8.x-5.x branch and so forth.

But there is no 8.x-5.x nor 8.x-6.x branch as of now. Again I think this is a sign that we should keep it simple and just define our own plugins and interfaces as we need them.

wundo’s picture

wundo CreditAttribution: wundo at Chuva Inc. for Chuva Inc. commented
shelane’s picture

shelane
Primary language English
CreditAttribution: shelane commented
Status: Needs work » Closed (won't fix)

This theme will not be supported for Bootstrap 4. See alternative themes for this support.