the preprocess method can be called many times during a page build, meaning that separately generating the theme information each time it is called gets expensive.

CommentFileSizeAuthor
#9 2905747-9.patch3.61 KBmarkhalliwell
#5 xhgui-bootstrap-profile-preprocess.png171.9 KBsylus
#2 bootstrap-theme_context_generation_expensive-2905747-2.patch1.63 KBacrollet
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

acrollet created an issue. See original summary.

acrollet’s picture

acrollet CreditAttribution: acrollet at roomify - online and open source reservation solutions commented
Status: Active » Needs review
FileSize
bootstrap-theme_context_generation_expensive-2905747-2.patch1.63 KB

patch attached for review.

acrollet’s picture

acrollet CreditAttribution: acrollet at roomify - online and open source reservation solutions commented
Issue tags: +Performance
acrollet’s picture

acrollet CreditAttribution: acrollet at roomify - online and open source reservation solutions commented

Forgot to mention figures, reduced page load times by an average of .30s (out of roughly 3)

sylus’s picture

sylus CreditAttribution: sylus commented
FileSize
xhgui-bootstrap-profile-preprocess.png171.9 KB

This looks great as another performance improvement ^_^, I also gave the patch a go and attached a profile comparison before and after the patch with a drush cr before each page load.

markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell at Tag1 Consulting commented
Status: Needs review » Postponed

See #2905729-8: Performance issues with theme alteration

markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell at Tag1 Consulting commented
Assigned: Unassigned » markhalliwell
Status: Postponed » Needs work

Same with this one.

markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell at Tag1 Consulting commented
Title: theme context generation in Bootstrap::preprocess() is expensive » Bootstrap::preprocess() theme context generation is expensive
markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell at Tag1 Consulting commented
Assigned: markhalliwell » Unassigned
Status: Needs work » Fixed
FileSize
2905747-9.patch3.61 KB

  • markcarver committed 43c1c4f on 8.x-3.x 
    Issue #2905747 by markcarver, acrollet, sylus: Bootstrap::preprocess()...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.