Per #2542050: Toolbar implementation creates super annoying re-rendering.
Above issue is fixing the flickering of Toolbar in CORE. Before & After above commits, there's still a problem in Bootstrap itself.
Bootstrap applied margin-top to BODY tag:
body {
margin-top: 15px;
}
Personally, I'd suggest to do it instead (either before or after above commit):
.navbar {
margin-top: 15px
}
So far, if that's really a case and must add the margin-top to BODY. here's another workaround for Bootstrap theme:
body {
margin-top: 15px;
}
body.toolbar-loading {
margin-top: 0;
}
.toolbar-loading #toolbar-administration {
margin-bottom: 15px;
}
** I have a look at source code. It's .min.css. I don't know the patch workflow of Bootstrap theme. Anyone knowing that please help to upload a patch. Thanks!
Comment | File | Size | Author |
---|---|---|---|
#5 | interdiff-2855957-3-5.txt | 802 bytes | njagojevic |
#5 | remove_bootstrap_flicking-2855957-5.patch | 854 bytes | njagojevic |
#3 | remove_bootstrap_flicking-2855957-3.patch | 884 bytes | njagojevic |
Comments
Comment #2
droplet CreditAttribution: droplet commentedComment #3
njagojevic CreditAttribution: njagojevic commentedThis patch applies the second suggestion from @droplet.
Comment #4
markhalliwellUsing an ID selector (
#toolbar-administration
) is likely overkill and generally considered bad practice. If possible this should implement the same logic using a class of some kind.Comment #5
njagojevic CreditAttribution: njagojevic commentedUsing
.toolbar
class instead ID selector#toolbar-administration
.Comment #7
markhalliwell