Per #2542050: Toolbar implementation creates super annoying re-rendering.

Above issue is fixing the flickering of Toolbar in CORE. Before & After above commits, there's still a problem in Bootstrap itself.

Bootstrap applied margin-top to BODY tag:

  body {
    margin-top: 15px;
  }

Personally, I'd suggest to do it instead (either before or after above commit):

  .navbar {
    margin-top: 15px
  }

So far, if that's really a case and must add the margin-top to BODY. here's another workaround for Bootstrap theme:

  body {
    margin-top: 15px;
  }
  body.toolbar-loading {
    margin-top: 0;
  }
  .toolbar-loading #toolbar-administration {
    margin-bottom: 15px;
  }

** I have a look at source code. It's .min.css. I don't know the patch workflow of Bootstrap theme. Anyone knowing that please help to upload a patch. Thanks!

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

droplet created an issue. See original summary.

droplet’s picture

Issue summary: View changes
njagojevic’s picture

Assigned: Unassigned » njagojevic
Status: Active » Needs review
FileSize
884 bytes

This patch applies the second suggestion from @droplet.

markhalliwell’s picture

Version: 8.x-4.x-dev » 8.x-3.x-dev
Assigned: njagojevic » Unassigned
Status: Needs review » Needs work
Issue tags: -toolbar-flicker

Using an ID selector (#toolbar-administration) is likely overkill and generally considered bad practice. If possible this should implement the same logic using a class of some kind.

njagojevic’s picture

Status: Needs work » Needs review
FileSize
854 bytes
802 bytes

Using .toolbar class instead ID selector #toolbar-administration.

  • markcarver committed 592a431 on 8.x-3.x authored by njagojevic
    Issue #2855957 by njagojevic, droplet: Remove Bootstrap Flicking
    
  • markcarver committed b66924e on 8.x-3.x
    Automated commit: grunt compile (CSS)
    
    Issue #2855957 by njagojevic,...
markhalliwell’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.