Create a site with navbar location set to normal/default and fluid containers, your container class gets repeated twice eg:

<header class="navbar navbar-inverse container-fluid" id="navbar" role="banner">
<div class="container-fluid">
...

Mistake is templates/system/page.html.twig:71

    <header{{ navbar_attributes.addClass(navbar_classes) }} id="navbar" role="banner">
      {% if not navbar_attributes.hasClass('container') %}
        <div class="{{ container }}">
      {% endif %} 

You are only checking to see if the container class has been applied previously, whereas it should test container and container-fluid.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mzealey created an issue. See original summary.

mzealey’s picture

Issue summary: View changes
njagojevic’s picture

Assigned: Unassigned » njagojevic
Status: Active » Needs review
FileSize
575 bytes
markhalliwell’s picture

Title: Setting container-fluid creates two containers in navbar region » Setting fluid container creates duplicate container inside navbar
Version: 8.x-3.1 » 8.x-3.x-dev
Assigned: njagojevic » Unassigned
Status: Needs review » Needs work

This should be using the existing container variable, not quoted strings.

Also, the above patch misses the closing div below that does the same thing.

  • markcarver committed abda003 on 8.x-3.x
    Issue #2845585 by njagojevic, mzealey, markcarver: Setting fluid...
markhalliwell’s picture

Status: Needs work » Fixed
FileSize
1.15 KB

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.