We have a bootstrap sub-theme of bootstrap. Recently the well class on the Secondary region disappeared and we noticed that the Components->Region Wells->Secondary was set to None. We have tried to set this back to ".well (normal)" but after saving the setting remains at "None". You can set the other values ".well-sm (small)" and ".well-lg (large)" but the ".well (normal)" value will not save.

The default for this setting seems to be ".well (normal)" but changing any other of the "Region Wells" values appears to clear the value for Secondary and it is impossible to reset it.

I've been trying to trace the code, but as I'm unfamiliar with a themes settings code I've been unable to trace exactly where this value should be saved. The function submitFormElement() in RegionWells.php appears to pass the correct value on but I'm not sure were to look in the code after this.

If anyone can point me to any code where I could check the values as they are being save I would be grateful.

CommentFileSizeAuthor
#9 bootstrap-page-elements.png9.67 KBimclean
#7 bootstrap-complex_settings_not_saved-2845407-7.patch1.13 KBxumepadismal

Comments

donaldp created an issue. See original summary.

donaldp’s picture

donaldp commented

If you export the setting using the configuration management, the well value does appear to have it's value set but the well neither appears in the html that is output or on the theme admin screen:

region_wells:
navigation: ''
navigation_col2: ''
navigation_bottom: ''
navigation_collapsible: ''
header: ''
highlighted: ''
help: ''
content: ''
sidebar_first: ''
sidebar_second: well
footer: ''
edu_footer: ''

zenimagine’s picture

zenimagine commented

Same problem for me. Did you find a solution ?

donaldp’s picture

donaldp commented

The only solution I found was to use ".well-lg (large)" which works OK. I tried to debug the code, but the interaction between the components is complicated. The setting appeared to persist until being rendered. Unfortunately time pressures forced me to give up. I have a hunch the problem may be due to this being the default setting.
The issues till seems to exist despite updates to Drupal core and the theme.

Christopher Riley’s picture

Christopher Riley commented

I too am running into this issue. I have verified that all original regions plus regions that I added can use any of the well settings. For the sidebar second I can choose well-lg and well-sm but not normal.

Suggestions would be appreciated

zenimagine’s picture

zenimagine commented

Same problem for me

xumepadismal’s picture

xumepadismal commented
StatusFileSize
new bootstrap-complex_settings_not_saved-2845407-7.patch1.13 KB

Here is the patch, it worked on my site well. However, the theme settings code is indeed somewhat complicated so I'm not sure whether it is the best or even valid solution for this issue. Maybe one of the maintainers will take a look...

markhalliwell’s picture

markhalliwell
Primary language English
commented
Assigned: Unassigned » markhalliwell
Status: Active » Needs review

the theme settings code is indeed somewhat complicated

Indeed. For this reason alone, I'll have to review this by reproducing the OP and then stepping through with the patch manually.

imclean’s picture

imclean commented
Issue summary: View changes
StatusFileSize
new bootstrap-page-elements.png9.67 KB

This doesn't by itself seem to resolve #2839565: Using a logo.png file in the theme folder doesn't work.

From a UI perspective, it's not clear what user action affects the config features.logo. "Use the logo supplied by the theme" refers to logo.use_default. Perhaps "Logo" could be an option under "Page Element Display".

emiliearenkid’s picture

emiliearenkid commented

Was this ever figured out? I am having the same problem where the default was a well in the Secondary location for blocks and I would like both the Primary and Secondary to be wells. However, when I changed the dropdown from "None" to ".well (normal)" for the Primary section in the settings for my Bootstrap subtheme and saved, the Secondary section changed from ".well (normal)" to "None" and I cannot change it to use any size well if the Primary dropdown uses any size well. If I set the Primary section back to using "None" I can have the Secondary section use any size well, though.

Edit: I tried changing the Secondary block to large and the Primary to normal and that seems to have worked, but other configurations do not necessarily work.

shelane’s picture

shelane
Primary language English
commented

What's strange is that I see the value set in the database config values for Bootstrap, but it doesn't show as the selected value in the UI.

noopal’s picture

noopal commented

I have something similar.
Can use well-sm and well-lg but not well.
If I select well it does not save.

imclean’s picture

imclean commented
Assigned: markhalliwell » Unassigned

  • shelane committed 80081e7 on 8.x-3.x authored by xumepadismal 
    Issue #2845407 by xumepadismal, imclean, donaldp, Christopher Riley,...
shelane’s picture

shelane
Primary language English
commented
Status: Needs review » Fixed

I manually tested all of the settings with the patch. I then tested content with wells and all other theme elements. Worked just as it should and so committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.