Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The tablesort indicator in views tables have incorrect class and wrap to the next line. It seems not themed properly and get's incorrect classes added to all images where it should not and therefore cause visual malfunctions.
Broken:
After bootstrap img-responsive
class is removed, it will positioned where it should be, but does not inherit the color of the label. Something that could work if we use _bootstrap_icon()
.
Original (non-bootstrap):
Fixed version:
Comment | File | Size | Author |
---|---|---|---|
#18 | 2840304-18-7.x-3.x.patch | 3.43 KB | markhalliwell |
#17 | 2840304-17-8.x-3.x.patch | 4.34 KB | markhalliwell |
Comments
Comment #2
hass CreditAttribution: hass commentedI have added theme_tablesort_indicator() to the theme. But for unknown reasons the html code returned is only shown in default sort order after a drupal cache clear.
There seems to be another bug and I have not found the source yet why the sort indicator disapears after resorting. Very strange behaviour.
It works without the theme override.
Comment #3
devshi.addweb CreditAttribution: devshi.addweb at AddWeb Solution Pvt. Ltd. commentedPlease put below code in your custom css file.
PFA screenshots for your help.
Comment #4
hass CreditAttribution: hass commentedThis is one workaround.
But I think we should override the sort icon. Not sure what icon we should use or if we use the dropdown/dropup from the navbar. Not sure what the maintainer prefers. Additionally the root cause of the disapearing icon need to be found.
Comment #5
hass CreditAttribution: hass commentedThat is the better one, but it does work only once after a cache clear and is no longer shown if you re-sort.
Comment #6
hass CreditAttribution: hass commentedMissed to add a screenshot of the fixed version
Comment #7
hass CreditAttribution: hass commentedI don't know why, but I cannot repro the disapearing caret again. Last patch #5 works well.
Comment #8
hass CreditAttribution: hass commentedComment #9
hass CreditAttribution: hass commentedComment #10
hass CreditAttribution: hass commentedStrings should be ucfirst.
Comment #11
markhalliwellComment #12
hass CreditAttribution: hass commentedI have not found any useful glyphicon. Please suggest one that works for names, numbers, money, dates, etc.
Comment #13
markhalliwellBootstrap::glyphicon('chevron-up')
and
Bootstrap::glyphicon('chevron-down')
Comment #14
hass CreditAttribution: hass commentedThere are several issues with _bootstrap_icon():
$attributes
.icon-after
to the header link (a.icon-after .glyphicon
) easily. tablesort_header() is not a theme function.How should this solved?
Comment #15
markhalliwell$attributes
parameter toBootstrap::glyphicon
as a follow up... instead of just complaining about it..icon-after
, but targeting table header cells and any icons inside them.Comment #16
markhalliwellComment #17
markhalliwell.
Comment #18
markhalliwell.