When displaying a file field the tooltip states "Open file in new window" but the link open in the same window.

It seems the target attribute for the link is not set. Attached is a patch that adds the target.

CommentFileSizeAuthor
#3 bootstrap_issues-2794523.patch609 bytesdeveldru
#2 after_patch.jpg121.38 KBAkshay kashyap
#2 before_patch.jpg181.11 KBAkshay kashyap
filelink.patch604 bytesDenis Danielyan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Denis Danielyan created an issue. See original summary.

Akshay kashyap’s picture

Akshay kashyap CreditAttribution: Akshay kashyap as a volunteer and at gai Technologies Pvt Ltd for gai Technologies Pvt Ltd commented
Status: Needs review » Needs work
FileSize
before_patch.jpg181.11 KB
after_patch.jpg121.38 KB

I have review the patch, apply successfully and working fine. I have attached after and before images.
But in the FileLink.php file found some indentation issue.

develdru’s picture

develdru CreditAttribution: develdru as a volunteer and at OpenSense Labs commented
Assigned: Unassigned » develdru
Status: Needs work » Needs review
FileSize
bootstrap_issues-2794523.patch609 bytes

Hi, I have created a patch file, please review.

thanks

develdru’s picture

develdru CreditAttribution: develdru as a volunteer and at OpenSense Labs commented
Assigned: develdru » Unassigned

markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell at Tag1 Consulting commented
Status: Needs review » Fixed
Issue tags: -file link target

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

vidhatanand’s picture

vidhatanand CreditAttribution: vidhatanand at OpenSense Labs commented

Is this committed to 3.x branch?

madmen’s picture

madmen CreditAttribution: madmen commented

?

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented

window.open('http://example.com/', '_blank');.I am using this JQuery code to open a link in new tab , for that i had to reverse this patch first , as it led to ambiguity. It shouldn't be made fixed here , sometimes it is not required to open external link in new tab , help tooltip text should have been changed.

markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell at Tag1 Consulting commented

It shouldn't be made fixed here

  1. window.open is just plain old JavaScript, not jQuery.
  2. You can prevent default behaviors for any element in JavaScript (including links from opening new tabs/windows). In fact, I actually just created a rudimentary example (without jQuery) for you: http://jsbin.com/zaturel/edit?html,js,console,output
  3. Generally speaking, clicking these file links (which are usually on edit pages of entities) shouldn't navigate you away from that page. Thus,
    that is why they open in a new window (for UI/UX purposes). If, for whatever reason, you don't like this default behavior... you are certainly entitled to create a sub-theme and remove this attribute from each item's attribute array.