The latest release of CTools, 7.x-1.9 (2015-Aug-19 ), includes an enhancement to provide the CTools modal style as a class on the modal. See #1532174: Add class containing the "modal style" to modal.

The overridden Drupal.CTools.Modal.show in this theme breaks this functionality.

CommentFileSizeAuthor
#4 2785145-bootstrap-ctools_modal_classes-4.patch870 byteskerasai
#2 2785145-bootstrap-ctools_modal_classes-1.patch1 KBkerasai
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kerasai created an issue. See original summary.

kerasai’s picture

kerasai CreditAttribution: kerasai at Breakthrough Technologies, LLC commented
Status: Active » Needs review
FileSize
2785145-bootstrap-ctools_modal_classes-1.patch1 KB

Patch includes the pertinent changes from CTool's modal.js implemented in Bootstrap theme's JS.

markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell at Tag1 Consulting commented
Status: Needs review » Needs work 
+++ b/sites/all/themes/bootstrap/js/modules/ctools/js/modal.js
@@ -99,8 +100,7 @@
-    $('#modalContent .modal-body').html(Drupal.theme(settings.throbberTheme));

Unrelated change.

kerasai’s picture

kerasai CreditAttribution: kerasai at Breakthrough Technologies, LLC commented
Status: Needs work » Needs review
FileSize
2785145-bootstrap-ctools_modal_classes-4.patch870 bytes

Well isn't that embarrassing?

Revised patch attached.

I also notice the loading throbber is again functioning with the latest patch.

  • markcarver committed 39a58ac on 7.x-3.x authored by kerasai 
    Issue #2785145 by kerasai: CTools Modal Classes Not Working
markhalliwell’s picture

markhalliwell
Primary language English
CreditAttribution: markhalliwell at Tag1 Consulting commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.