Fix navbar collapsed

approve.
patch works.

+++ b/bootstrap_subtheme/less/overrides.less
@@ -305,3 +305,17 @@ div.password-suggestions ul {
+ul.secondary {
+  float: right;
+}
+
+@media (max-width: @screen-sm) {
+  .logo {
+    margin-left: 15px;
+  }
+
+  ul.secondary {
+    float: left;
+  }
+}

Now that Bootstrap is technically mobile first, we should reverse this so it only applies a float on tablet and above.

Also, go ahead and take out the logo modifications. We have #2094411: Create new logo which will probably alter this anyway.

Should be this way, or am i wrong?

That looks right, yes... but I'd like someone to review this manually.

+++ b/bootstrap_subtheme/less/overrides.less
@@ -305,3 +305,11 @@ div.password-suggestions ul {
+@media @tablet, @normal, @wide {

In reality, this should probably just be:

@media @tablet {}

But the variables need to be updated to be a min-width, not set sizes.

So the following changes are in this patch.
* fix navbar element floating on mobile displays
* reworked all media queries to be mobile first.

Sorry to do this, but I was in the middle of #2098175: Clean up files and now the structure has completely changed (to be easier for maintaining). Please re-roll your patch against the latest HEAD. Also, be sure to read the documentation in template.php to understand what has changed. Thanks!

Thats a lot of new files ^^
But this patch should be fine. Only the menu function moved to theme/menu/...
No big deal.

warning: 1 line adds whitespace errors.

Fixed and Committed!

Ohh Valkum, I'm sorry, I forgot to change the commit author.

I just fixed a few things, but gave @valkum credit since there was a mishap :)

Committed 29dfb51 to 7.x-3.x.

Ohh i missed a MQ. sry. @wundo, no problem.

12: bootstrap-add-navbar-fix-and-mobile-first-changes-for-override-less-2094991-12.patch queued for re-testing.

Don't retest patches that have already been committed to code (they will always fail).

Oops, wrong status.