Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Breaking off per #1844448-48: Add sub-theme starter kit. Code needs to be refactored so if a Bootstrap sub-theme has chosen to use the CDN, it will add the appropriate CSS & JS files via the Bootstrap base theme , otherwise it shouldn't add anything.
Comment | File | Size | Author |
---|---|---|---|
#1 | 1957620-bootstrap-refactor_code_cdn-1.patch | 4.98 KB | markhalliwell |
Comments
Comment #1
markhalliwellAttaching patch. The CDN is enabled by default (to provide the "out-of-box" experience). I also went ahead and added the latest 2.3.1 version. Essentially, the base theme no longer provides support (other than the CDN) for adding the Bootstrap library CSS and JS files. If a sub-theme chooses to use source files (compiled or otherwise), then it will need to download the Bootstrap library in it's sub-folder, disable the CDN setting in it's .info file and provide it's own CSS and JS declarations.
Also, I was tempted to put this comment in
includes/theme.inc line 296
regarding the bootstrap_ui module. I ultimately didn't as there are already issues regarding this, so I'll just reference it here (the README should probably be updated after a solution to these problems exists):Comment #2
markhalliwellForgot to change the status.
Also, should be mentioned that this patch is after changes made in #1846736: Remove jQuery CDN setting in favor of using jQuery Update module.
Comment #4
markhalliwellYeah... I thought this might happen. Will need to re-test after #1846736: Remove jQuery CDN setting in favor of using jQuery Update module has been committed to dev.
Comment #5
markhalliwell#1: 1957620-bootstrap-refactor_code_cdn-1.patch queued for re-testing.
Comment #6
markhalliwellMarked #1960678: bootstrap.js is loaded from Bootstrap theme as a dup of this issue.
Comment #7
wundo CreditAttribution: wundo commented#1: 1957620-bootstrap-refactor_code_cdn-1.patch queued for re-testing.
Comment #8
markhalliwellIt passed.
Comment #9
wundo CreditAttribution: wundo commentedCommitted, thanks :)