Hello,

In template.php, there is a function bootstrap_preprocess_node that add the row-fluid class to the node when this is the teaser.

I suggest to remove it. Not all people want to add row-fluid class here (this is my case) and it's better to add it to the template files (.tpl.php files) to add flexibility for themers.

Regards,

Alex

CommentFileSizeAuthor
#1 bootstrap-remove-row-fluid-1841628-1.patch768 bytesmarkhalliwell

Comments

markhalliwell’s picture

markhalliwell
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new bootstrap-remove-row-fluid-1841628-1.patch768 bytes

I'm ok with this, especially since #1967860: Page template uses .row class instead of .row-fluid was already committed and this preprocess function isn't needed anymore. Not sure why row would be more beneficial than row-fluid, but if that's what you "need" then override the page.tpl.php template file now.

markhalliwell’s picture

markhalliwell
Primary language English
commented

@zmove is this an acceptable solution for you? (and others, please chime in)

markhalliwell’s picture

markhalliwell
Primary language English
commented

Anyone else have any objections to this before I commit it?

andregriffin’s picture

andregriffin commented
Status: Needs review » Reviewed & tested by the community

Seems like a good idea to me.

markhalliwell’s picture

markhalliwell
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Fixed in commit 45ce597.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.