Double index creation & PostgreSQL [#637002]

Hi guys,

I had an error when updating the database about the files timestamp index creation failing. So I checked the code really quick and I found this:

1) You call the same function twice with the exact same parameters

2) You use the MySQL incompatible command: "SHOW INDEX FROM ...", which means PostgreSQL people will get an error, although minor (i.e. it just says it cannot create the index and moves on.)

  _boost_index_exists($ret, 'node_revisions', 'timestamp');
  _boost_index_exists($ret, 'files', 'timestamp');
  _boost_index_exists($ret, 'comments', 'timestamp');
  _boost_index_exists($ret, 'node', 'changed');
  _boost_index_exists($ret, 'files', 'timestamp');
  _boost_index_exists($ret, 'node_comment_statistics', 'last_comment_timestamp');
  _boost_index_exists($ret, 'votingapi_vote', 'timestamp');

Thank you.
Alexis Wilke

Comment	File	Size	Author
#7	boost-637002.patch	1.51 KB	mikeytown2
#7
#3	boost-637002.patch	1.28 KB	mikeytown2
#3

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

mikeytown2 CreditAttribution: mikeytown2 commented 19 November 2009 at 09:35

Can I get the output of this sql command from you?

SELECT * FROM pg_indexes WHERE tablename = 'node_revisions';

Comment #2

AlexisWilke CreditAttribution: AlexisWilke commented 19 November 2009 at 20:28

You will get this:

drupal=# SELECT * FROM pg_indexes WHERE tablename = 'node_revisions';
 schemaname |   tablename    |          indexname           | tablespace |                                       indexdef                                        
------------+----------------+------------------------------+------------+---------------------------------------------------------------------------------------
 public     | node_revisions | node_revisions_timestamp_idx |            | CREATE INDEX node_revisions_timestamp_idx ON node_revisions USING btree ("timestamp")
 public     | node_revisions | node_revisions_uid_idx       |            | CREATE INDEX node_revisions_uid_idx ON node_revisions USING btree (uid)
 public     | node_revisions | node_revisions_nid_idx       |            | CREATE INDEX node_revisions_nid_idx ON node_revisions USING btree (nid)
 public     | node_revisions | node_revisions_pkey          |            | CREATE UNIQUE INDEX node_revisions_pkey ON node_revisions USING btree (vid)

So if you get indexname I guess you'd get what you need. 8-)

Thank you.
Alexis