I have boost set NOT to cache on errors.
I use the Boost Cache Status block to provide cache details so I can see if anonymous users are being served the cache and also to clear the cache for views where the node has changed.
However, the cache status block always returns the error "There are php errors or drupal messages on this page, preventing boost from caching."
This is triggered if there is either an error or a message AND either the "do not cache on errors" or "do not cache on messages" is on. As "do not cache on errors" is on AND there is always a message (I use Revisioning), I never see cache info and the flush button, even if the cache exists.
Should/can the line in Boost module be:
if ( (BOOST_HALT_ON_ERRORS && error) || (BOOST_HALT_ON_MESSAGES && $drupal_msg != 0) ) {
rather than
if ((BOOST_HALT_ON_ERRORS || BOOST_HALT_ON_MESSAGES) && ($error || $drupal_msg != 0)) {
?
Comment | File | Size | Author |
---|---|---|---|
#1 | boost-598044.patch | 1.58 KB | mikeytown2 |
Comments
Comment #1
mikeytown2 CreditAttribution: mikeytown2 commentedThanks, this is a follow up to this issue
#586138: Split "Do not cache if error on page" into drupal msgs and php errors
Comment #2
mikeytown2 CreditAttribution: mikeytown2 commentedcommitted