Boost with Redirect Module and 301

I have the same problem on 2 sites.
In both cases I had to disable Boost.

Referenced here: #1957530: Redirect and Boost?

I'm having this problem as well; initially I thought it should be a Redirect issue, but now I'm not so sure. Redirect exits by calling drupal_exit, which seems correct, but which then triggers boost_exit.

However, redirect has set the header status to 301. So once $_boost['header_info'] = boost_get_header_info(); is called, can boost_exit then ignore all pages where $_boost['header_info']['status'] matches 301/302?

I think apemantus is right. Boost should not create cache file if redirect status code set to 301 or 302. We don't need to cache redirect pages. I added following code to boost_exit function:

  // Skip writing data to a file if other module created redirect.
  $redirect_status_codes = array('301', '302');
  if (in_array($_boost['header_info']['status-number'], $redirect_status_codes)) {
    return;
  }

I added my code after following code:

  // Get header info.
  $_boost['header_info'] = boost_get_header_info();
  $_boost['matched_header_info'] = boost_match_header_attributes($_boost['header_info']);
  if ($_boost['matched_header_info']['enabled'] === FALSE) {
    return;
  }

Please test it and let me know if it works for you. If it works I will create patch then.

If I'm not mistaken, shouldn't boost not apply if the $destination parameter passed to boot_exit() is not empty? Wouldn't that cover all redirect cases? Is there a valid reason we'd want Boost to cache any redirects of any kind?

I tried #7 but not working I think...

I can give my little workaround, in boost.module, line 307 (on DEV version)

I replace this :

if ($_boost['matched_header_info']['enabled'] === FALSE) {
    return;
}

By this :

$data_test = preg_replace('/[\s\r\n]+/Uims','', strip_tags($data));  
if ($_boost['matched_header_info']['enabled'] === FALSE || empty($data_test)) {
  return;
}

Hope this help...

Here is the original idea : https://drupal.org/node/1176534

I agree with Dave Reid in #8. The Boost module previously attempted to solve this problem in boost_drupal_goto_alter() but the redirect module doesn't call drupal_goto(). I don't see any reason not to move that logic into boost_exit(). Patch attached.

Previous patch had some whitespace cruft.

Works for me!

Yep - works for me to - this has been a bit of a pain this issue, as previously had to whitelist a ton of redirects. Thanks!

Not sure what @14 is talking about :S.

Applies fine for me on both stable (1.0) & dev (1.x). Without the patch applied users requesting pages which redirect can be served up a blank page. This should hopefully be low hanging fruit for maintainers, patch works a treat.

Works perfectly for a long time on several sites; please apply to the dev version at least.

Could the maintainers please commit this to DEV? (One patch less to have to keep applying on multiple sites.)

This is working for my site as well.

Would appreciate to commit this...

If I wanted to apply this speicifc patch to my stable version 7.x-1.0 inmy production site how would I go about doing this?

I am fairly new to drupal patches but I have some programming know how (just enough to be dangerous) I need this for my site and don't want to wait for SEO ressons when it's offically released.

As I currently understand this, I need to go to the boost module folder, find the file named boost.module and make some changes. If I am on the right path, what do I need to replace?

Any help appreciated.

Makimaki

You can manually apply the patch by removing the lines that start with the minus sign: -
and adding the lines that start with the plus sign: +
in the order that the patch files shows

e.g. for the patch file https://www.drupal.org/files/issues/boost_redirect-1957532-11.patch, edit the boost.module and remove the entire function boost_drupal_goto_alter(), and add an if statement inside the function boost_exit()

More information: https://www.drupal.org/patch/apply

Thank you. Thank you, aufumy. You are an angel. It works and I learned something new. It's not so difficult after all. Thanks once again.

Patch applies cleanly on 7.x-1.0 and it fixes the problem.

I think we need to leave the implementation of hook_drupal_goto_alter(). Even though Redirect doesn't use drupal_goto(), lots of modules do, including core Search (see search_view() which uses drupal_goto() when visiting /search). See #1176534: Bypass caching on redirects.

Had exactly the same problem. #11 solved it.
Thank you azinck.

@joelstein. Good point. Patch updated to retain boost_drupal_goto_alter()

Applying the patch from @azinck in #25 worked for me. Thanks!

#25 fixed it for me too.

#25 solved the problem and is rolling without problems in production environment.

Commited to 7.x-1.x.

Thanks! (and sorry it took so long

I've rerolled the patch in #25 for a Drupal 6 site.