Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
At work they still use ie7... I noticed the tabs don't align with the content area
see attached image
Comment | File | Size | Author |
---|---|---|---|
#8 | bluecheese.patch | 514 bytes | drumm |
#7 | bluecheese.patch | 516 bytes | drumm |
#7 | About Drupal - tvn drupal dev.png | 250.5 KB | drumm |
ie7_bug.jpg | 4.84 KB | Argus |
Comments
Comment #1
MustangGB CreditAttribution: MustangGB commentedAlso occurs in WebKit browsers when zooming in/out (tested in Chrome)
This is due to https://bugs.webkit.org/show_bug.cgi?id=60318
But it should be an easy fix for us:
Comment #2
oadaeh CreditAttribution: oadaeh commentedThis also happens in Chromium 18.0.1025.142 for Linux. A similar problem happens for Firefox 11.0 for Linux, except that the tabs are lower than where they should be.
@akamustang: please attach a patch before marking an issue with needs review. However, your proposed code does fix both issues for me. We just need a proper patch to get it applied. I'm not committing to anything here, but if I get a few moments and a few things out of my current queue, I will do that.
Comment #2.0
oadaeh CreditAttribution: oadaeh commentedtypo
Comment #3
MustangGB CreditAttribution: MustangGB commentedIIRC Bluecheese has not publicly been released, at least I couldn't find the source for it, hence why I was not able to roll a patch
Comment #4
oadaeh CreditAttribution: oadaeh commented@akamustang: it appears you are correct. I was under the mistaken impression that code could be obtained for bug fixes, etc.
Comment #5
MustangGB CreditAttribution: MustangGB commentedThe WebKit issue mentioned in #1 has landed and has actually made the issue worse.
In Chrome 21 at the default zoom level of 100% there is now always a gab under #nav-masthead.
---
#header
16px*0.8125em*22.153846em=287.999998px
#nav-header
16px*0.8125em*1.384615em+16px*0.8125em*0.923076em*(0.333333em+0.333333em)=25.999979000008px
#header-content
16px*0.8125em*18em=234px
#nav-masthead
16px*0.8125em*1.384615em+16px*0.8125em*0.923076em*(0.416666em+0.416666em)=27.999969000016px
---
#header != #nav-header + #header-content + #nav-masthead
287.999998px != 285.9333343505859px
The calculations are a bit off as I did it really quickly sitting at a tiny screen, but you get the idea.
Comment #6
ParisLiakos CreditAttribution: ParisLiakos commentedYeah, coming from chromium 21..looks ugly
#1 fixes it
Comment #7
drummTried out #1 and it does fix the home page, but breaks all other pages a bit more. See attached screenshot.
Also attached is a patch for what I did. If you want to try out more changes on a dev site, see http://drupal.org/node/1018084.
Comment #8
drummActually, I should have kept that height. New patch attached.
Please browser test http://tvn-drupal.redesign.devdrupal.org/ and http://tvn-drupal.redesign.devdrupal.org/about, where this change is deployed. I want to know it works in IE 8+ and reasonable versions of WebKit and FireFox.
Comment #9
oadaeh CreditAttribution: oadaeh commentedBoth pages look fine to me in both Firefox 14.0.1 and Chromium 18.0.1025.168, running on LinuxMint 13.
Comment #10
ParisLiakos CreditAttribution: ParisLiakos commentedSame here for me on Debian and Chromium 21.0.1180.75..
I launched though my VB with WS 7 and checked with IE9 and IE8 from IE9's compatibility mode and Firefox 11, it works perfect
Comment #11
MustangGB CreditAttribution: MustangGB commented#8
Working fine in Chrome 21
Comment #12
tvn CreditAttribution: tvn commentedMost noticeable this problem is on "Page not found" page, space between tabs and content area is huge.
Dev site looks good in the latest FireFox, Opera, Chrome and IE on Windows 7. RTBC!
Comment #13
drummCommitted & deploying later today.
Comment #14
MustangGB CreditAttribution: MustangGB commented<3
Comment #15
ParisLiakos CreditAttribution: ParisLiakos commentedawesomeness.
My eyes thank you drumm
Comment #16.0
(not verified) CreditAttribution: commentedCorrected a typo