Issue fork blocktabs-3429026

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

Status: Active » Needs review
StatusFileSize
new344 bytes

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #11-120835

This patch was created using these packages:

  1. drupal/upgrade_status: 4.1.0
  2. mglaman/phpstan-drupal: 1.2.7
  3. palantirnet/drupal-rector: 0.20.1

ajitdalal made their first commit to this issue’s fork.

ajitdalal’s picture

Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new35.41 KB
new38.9 KB
new27.72 KB

I reviewed and tested MR#8 no issue with D11 installation and upgrade rector no issue reported,
MR https://git.drupalcode.org/project/blocktabs/-/merge_requests/8 ready to merge for D11 compatibility release.
artefacts attached

muratk’s picture

Can't apply the patch because the patch expects:

core_version_requirement: ^9.2 || ^10

While blocktabs.info.yml of version 2.0.0-alpha1 contains:

core_version_requirement: ^10.1

So perhaps the rector patch should be adjusted.

muratk’s picture

also missing, apparently, is the update on the file: blocktabs_bootstrap/blocktabs_bootstrap.info.yml file, which contains the line

core_version_requirement: ^10.1

muratk’s picture

Correction on #7 and #8: I didn't realize that the patch needed to be applied to the tail end of version 1 and not the start of version 2. so I was able to make the module ready for Drupal 11 by applying the patch on version 1.

It has to be noted that the version 2.0.0-alpha1 is specified for Drupal 10 and not 11.

Ignore #8 altogether.