The only difference between 7.x-1.x and 7.x-2.x is that the latter generates region names with an underscore instead of a hyphen #2160669: Use underscore instead of hyphen for dynamically generated region names. However, this change broke the Block Group integration of the Region Class module.
Add a new function blockgroup_region_for_blockgroup() such that contrib modules do not have to guess the separator according to the installed module version.
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | 7.x-1.x-add_a_function_to-2486837-11.patch | 4.73 KB | znerol |
| #8 | interdiff.txt | 650 bytes | znerol |
| #8 | add_a_function_to-2486837-8.patch | 4.77 KB | znerol |
| #7 | interdiff.txt | 648 bytes | znerol |
| #7 | add_a_function_to-2486837-7.patch | 4.13 KB | znerol |
Comments
Comment #1
znerol commentedSomething like this perhaps.
Comment #3
znerol commentedComment #4
znerol commentedI'm not happy with the new function names. Also I hate the brittle
substrcomparison. Therefore, let's renameblockgroup_region_for_blockgroup()intoblockgroup_get_region()and removeblockgroup_region_is_blockgroup()and instead compare againstblockgroup_region_list(). Also introduce a static cache for the latter.Comment #6
znerol commentedRegion list needs to be initialized to an empty array.
Comment #7
znerol commentedUse references when moving regions into
$page['#blockgroups']. This is how it works in HEAD.Comment #8
znerol commentedAlso use the new function in the test case.
Comment #10
znerol commentedComment #11
znerol commentedBackport to 7.x-1.x.
Comment #12
znerol commentedComment #14
znerol commented