I came across an error while saving my blockcache_alter settings on the block form.
Turns out the VARCHAR that saves the delta, was not long enough.

Increasing the value from 32 to 64 characters seems to solve the issue.

Thx for this module!

CommentFileSizeAuthor
#2 blockcache_alter-database-incompatibility-2042943-#1.patch912 bytesFabianMeul
#1 blockcache_alter-database-incompatibility-2042943.patch449 bytesFabianMeul

Comments

FabianMeul’s picture

FabianMeul commented
StatusFileSize
new blockcache_alter-database-incompatibility-2042943.patch449 bytes

Patch attached.

TODO: Write a schema that changes the table definition using update.php

FabianMeul’s picture

FabianMeul commented
StatusFileSize
new blockcache_alter-database-incompatibility-2042943-#1.patch912 bytes

Patch attached with included update hook.

fabianx’s picture

fabianx commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Looks good to me. **RTBM**

fabianx’s picture

fabianx commented

This should be correct given that core's block table also only has 32 chars, but I am not opposed to this and this is not in the critical path, so committing ...

fabianx’s picture

fabianx commented
Status: Reviewed & tested by the community » Fixed

Fixed during commit:

diff --git a/blockcache_alter.install b/blockcache_alter.install
index bf5dc9c..c3bfc3e 100644
--- a/blockcache_alter.install
+++ b/blockcache_alter.install
@@ -52,7 +52,6 @@ function blockcache_alter_schema() {
  * Fix the length of the delta VARCHAR to 64
  */
 function blockcache_alter_update_7001(&$sandbox) {
-  
   db_change_field('blockcache_alter', 'delta', 'delta', array(
     'type' => 'varchar',
     'length' => 64,
@@ -60,5 +59,4 @@ function blockcache_alter_update_7001(&$sandbox) {
     'default' => '0',
     'description' => 'Unique ID for block within a module.',
   ));
-  
-}
\ No newline at end of file
+}

  • Fabianx committed 8a2e54a on 7.x-1.x authored by FabianMeul 
    Issue #2042943 by FabianMeul: Fixed Database table incompatibility.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.