Test for visibility group creation through UI [#2574629]

Comment	File	Size	Author
#17	interdiff-17.patch	703 bytes	joshi.rohit100
8.x-1.x: PHP 5.5 & MySQL 5.5 1 fail PHP 5.6 & MySQL 5.5 1 fail
#17	2574629-17.patch	5.15 KB	joshi.rohit100
8.x-1.x: PHP 5.5 & MySQL 5.5 2 pass PHP 5.6 & MySQL 5.5 2 pass
#16	test_for_visibility-2574629-16.patch	4.9 KB	tedbow
8.x-1.x: PHP 5.5 & MySQL 5.5 2 pass PHP 5.6 & MySQL 5.5 2 pass
#15	test_for_visibility-2574629-15.patch	7.61 KB	tedbow
8.x-1.x: PHP 5.5 & MySQL 5.5 2 pass PHP 5.6 & MySQL 5.5 2 pass
#13	2574629-13.patch	4.23 KB	joshi.rohit100
8.x-1.x: PHP 5.5 & MySQL 5.5 2 pass, 1 fail
#12	2574629-12.patch	4.04 KB	joshi.rohit100

#11	block-visibilty-group-creation-ui-11.patch	3.95 KB	joshi.rohit100

#5	block-visibilty-group-creation-ui.patch	3.94 KB	joshi.rohit100
8.x-1.x: PHP 5.6 & MySQL 5.5 CI error
#3	block-visibilty-group-creation-ui.patch	3.94 KB	joshi.rohit100
8.x-1.x: PHP 5.6 & MySQL 5.5 CI error
#2	block-visibilty-group-creation-ui.patch	3.94 KB	joshi.rohit100

Comment #1

25 September 2015 at 09:48

joshi.rohit100 created an issue. See original summary.

Log in or register to post comments

Comment #2

joshi.rohit100

he/him

Hindi

Delhi, India

CreditAttribution: joshi.rohit100 commented 25 September 2015 at 12:47

Status:

Active

» Needs review

File	Size
block-visibilty-group-creation-ui.patch	3.94 KB

here we go.

Log in or register to post comments

Comment #3

joshi.rohit100

he/him

Hindi

Delhi, India

CreditAttribution: joshi.rohit100 commented 25 September 2015 at 12:53

File	Size
block-visibilty-group-creation-ui.patch	3.94 KB
8.x-1.x: PHP 5.6 & MySQL 5.5 CI error

re-uploading

Log in or register to post comments

Comment #4

25 September 2015 at 12:56

Status:

Needs review

» Needs work

The last submitted patch, 3: block-visibilty-group-creation-ui.patch, failed testing.

Log in or register to post comments

Comment #5

joshi.rohit100

he/him

Hindi

Delhi, India

CreditAttribution: joshi.rohit100 commented 25 September 2015 at 13:01

Status:

Needs work

» Needs review

File	Size
block-visibilty-group-creation-ui.patch	3.94 KB
8.x-1.x: PHP 5.6 & MySQL 5.5 CI error

mis-named test directory name ):

Log in or register to post comments

Comment #6

25 September 2015 at 13:04

Status:

Needs review

» Needs work

The last submitted patch, 5: block-visibilty-group-creation-ui.patch, failed testing.

Log in or register to post comments

Comment #7

tedbow

he/him

English

Ithaca, NY, USA

CreditAttribution: tedbow at Six Mile Tech commented 25 September 2015 at 14:22

Status:

Needs work

» Needs review

Log in or register to post comments

Comment #8

tedbow

he/him

English

Ithaca, NY, USA

CreditAttribution: tedbow at Six Mile Tech commented 25 September 2015 at 14:24

I turned off "Continuous integration tests" because it looks like it fails without a unit test. You might need to resubmit.

Log in or register to post comments

Comment #9

tedbow

he/him

English

Ithaca, NY, USA

CreditAttribution: tedbow at Six Mile Tech commented 25 September 2015 at 14:36

Status:

Needs review

» Needs work

Not sure if there is problem with my set up but when I try to run the tests locally I get:

The website encountered an unexpected error. Please try again later.

ReflectionException: Class Drupal\block_visibility_groups\Tests\BlockVisibilityGroupsTestBase does not exist in ReflectionClass->__construct() (line 306 of core/modules/simpletest/src/TestDiscovery.php).

I am using core 8.0.0-beta15

Log in or register to post comments

Comment #10

25 September 2015 at 16:48

The last submitted patch, 5: block-visibilty-group-creation-ui.patch, failed testing.

Log in or register to post comments

File	Size
block-visibilty-group-creation-ui-11.patch	3.95 KB

Comment #12

joshi.rohit100

he/him

Hindi

Delhi, India

CreditAttribution: joshi.rohit100 commented 27 September 2015 at 06:44

File	Size
2574629-12.patch	4.04 KB

somehow forgot to mention @group ):

Log in or register to post comments

Comment #13

joshi.rohit100

he/him

Hindi

Delhi, India

CreditAttribution: joshi.rohit100 commented 1 October 2015 at 03:22

File	Size
2574629-13.patch	4.23 KB
8.x-1.x: PHP 5.5 & MySQL 5.5 2 pass, 1 fail

One problem here it is showing that we have ConditionsSetFormTrait trait which is using StringTranslationTrait and also for example, we are extending FormBase class by BlockVisibilityGroupForm which also using that string translation trait. So there is collision in the $this->t() in some classes which are using this new trait and extending core classes which already have this transaltion trait.

But I think, it is not related with test, so here we go....

Log in or register to post comments

Comment #14

1 October 2015 at 03:30

Status:

Needs review

» Needs work

The last submitted patch, 13: 2574629-13.patch, failed testing.

Log in or register to post comments

Comment #15

tedbow

he/him

English

Ithaca, NY, USA

CreditAttribution: tedbow at Six Mile Tech commented 1 October 2015 at 22:51

Status:

Needs work

» Needs review

File	Size
test_for_visibility-2574629-15.patch	7.61 KB
8.x-1.x: PHP 5.5 & MySQL 5.5 2 pass PHP 5.6 & MySQL 5.5 2 pass

I have attached a patch that fixes the trait problem with ConditionsSetFormTrait that cause a drupalci testing error.

Log in or register to post comments

Comment #16

tedbow

he/him

English

Ithaca, NY, USA

CreditAttribution: tedbow at Six Mile Tech commented 1 October 2015 at 23:39

File	Size
test_for_visibility-2574629-16.patch	4.9 KB
8.x-1.x: PHP 5.5 & MySQL 5.5 2 pass PHP 5.6 & MySQL 5.5 2 pass

Attached patch that remove translation function also does use StringTranslationTrait

So only works because all classes that use this trait also use StringTranslationTrait or least has t function.

The previous patch relies on method_exists which probably is wasteful.

Log in or register to post comments

Comment #17

joshi.rohit100

he/him

Hindi

Delhi, India

CreditAttribution: joshi.rohit100 commented 2 October 2015 at 05:58

File	Size
2574629-17.patch	5.15 KB
8.x-1.x: PHP 5.5 & MySQL 5.5 2 pass PHP 5.6 & MySQL 5.5 2 pass
interdiff-17.patch	703 bytes
8.x-1.x: PHP 5.5 & MySQL 5.5 1 fail PHP 5.6 & MySQL 5.5 1 fail

Log in or register to post comments

Comment #18

2 October 2015 at 06:04

Status:

Needs review

» Needs work

The last submitted patch, 17: interdiff-17.patch, failed testing.

Log in or register to post comments

Comment #19

2 October 2015 at 06:04

The last submitted patch, 17: interdiff-17.patch, failed testing.

Log in or register to post comments

Comment #20

joshi.rohit100

he/him

Hindi

Delhi, India

CreditAttribution: joshi.rohit100 commented 2 October 2015 at 06:18

Status:

Needs work

» Needs review

Oops! wrong extension for interdiff

Log in or register to post comments

Comment #21

4 November 2015 at 14:44

tedbow committed da6f58a on 8.x-1.x authored by joshi.rohit100

Issue #2574629 by joshi.rohit100, tedbow: Test for visibility group...

Log in or register to post comments

Comment #22

tedbow

he/him

English

Ithaca, NY, USA

CreditAttribution: tedbow at Six Mile Tech commented 4 November 2015 at 14:53

Status:

Needs review

» Fixed

@joshi.rohit100 thanks so much for the patch. Sorry it took me so long to get back to this. Test patches are especially appreciated because they make development so much easier.