Problem/Motivation

In ChooseBlockController.php we are checking to see if the mime type is image/svg however some SVG's include the +xml.

Steps to reproduce

Proposed resolution

Make the if (mime_content_type($icon_path) === "image/svg") check a bit less specific.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#3 3353888-update_svg_mimetype_check.patch953 bytescarolpettirossi

Issue fork block_library-3353888

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

AaronChristian created an issue. See original summary.

AaronChristian opened merge request !4

carolpettirossi’s picture

carolpettirossi commented
StatusFileSize
new 3353888-update_svg_mimetype_check.patch953 bytes

Attaching patch from MR#4 to use with composer

carolpettirossi’s picture

carolpettirossi commented
Status: Active » Reviewed & tested by the community

I've been using patch from MR and it's working properly. Changing to RTBC

rajab natshah’s picture

rajab natshah
he/him
commented

I agree that having this will be better
Aaron, Can you merge and release?

rajab natshah’s picture

rajab natshah
he/him
commented

#3467583: Offering to co-maintain Block Library
#3470964: Offering to co-maintain Block Library

rajab natshah’s picture

rajab natshah
he/him
commented

Aaron, would you like to co-maintain the Block Library module?

rajab natshah’s picture

rajab natshah
he/him
commented
Title: Update SVG mimetype check » Add support for svg's with mime types that include +xml appended

rajab natshah’s picture

rajab natshah
he/him
commented
Assigned: aaronchristian » Unassigned
Status: Reviewed & tested by the community » Fixed
Issue tags: +block_library-1.0.1
rajab natshah’s picture

rajab natshah
he/him
commented

✅ Released block_library-1.0.1

aaronchristian’s picture

aaronchristian commented

Awesome thanks @Rajab! 🔥

Yes i would love to help maintain the module. Thanks for asking!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.