Notice: Trying to get property of non-object in block_class_preprocess_panels_pane() [#2696177]

Comment	File	Size	Author
#2	block_class-2696177-2-7.x.patch	519 bytes	wtrv
7.x-2.x: PHP 5.3 & MySQL 5.5, D7 8 pass

Comment #1

29 March 2016 at 13:49

wtrv created an issue. See original summary.

Log in or register to post comments

Comment #2

wtrv CreditAttribution: wtrv at Wunder commented 29 March 2016 at 13:57

File	Size
block_class-2696177-2-7.x.patch	519 bytes
7.x-2.x: PHP 5.3 & MySQL 5.5, D7 8 pass

Patch attached

Log in or register to post comments

Comment #3

wtrv CreditAttribution: wtrv at Wunder commented 29 March 2016 at 13:57

Status:

Active

» Needs review

Log in or register to post comments

Comment #4

DYdave CreditAttribution: DYdave at DAVYIN Internet Solutions / 戴文信息科技有限公司 commented 30 March 2016 at 07:06

@wtrv

How to reproduce the bug?
Care to elaborate a little bit more than just pasting the notice?

Any relationship with #1386774: Panels and related modules: Compatibility issues....

Talk about really doing the bare minimum.....

Log in or register to post comments

Comment #5

wtrv CreditAttribution: wtrv at Wunder commented 30 March 2016 at 07:52

Hi Dave,

The bug is happening the instant the Block class module is enabled together with the panels module.

Once the block_class_preprocess_panels_pane function is hit, the notice is thrown because there was no check wether the $var['pane'] variable is indeed an object and $vars['pane']->type is not in fact empty.

It is in fact related to #1386774: Blocks in panel panes, but because of the minor alteration I did not reopen the issue.

I'm still trying to get the hang of this.. so I would appreciate it if you would refrain from such comments in the future.

Log in or register to post comments

Comment #6

DYdave CreditAttribution: DYdave at DAVYIN Internet Solutions / 戴文信息科技有限公司 commented 30 March 2016 at 08:07

Hi @wtrv,

Thanks a lot for the speedy reply and the additional information.

We definitely greatly appreciate your efforts of contribution to the module.

so I would appreciate it if you would refrain from such comments in the future.

Nothing personal, just had to let everybody else know that we had very little (almost nothing) on the problem you just reported.

You tagged 7.x-2.3, have you tried testing the issue with block_class-7.x-2.x-dev.
Additionally, I know panels and ctools have been undergoing quite a lot of changes, it would be fantastic if you could please specify the version of the related modules?

Thanks again very much for your reporting/testing, feedback and comments.

Log in or register to post comments

Comment #7

DYdave CreditAttribution: DYdave at DAVYIN Internet Solutions / 戴文信息科技有限公司 commented 30 March 2016 at 08:14

Version:	7.x-2.3	» 7.x-2.x-dev
Related issues:		+#1386774: Panels and related modules: Compatibility issues

Sorry, didn't see 7.x-2.3 is actually the same as the dev atm.
Changing version.

Log in or register to post comments

Comment #8

DYdave CreditAttribution: DYdave at DAVYIN Internet Solutions / 戴文信息科技有限公司 commented 30 March 2016 at 08:36

Assigned:	wtrv	» Unassigned
Priority:	Minor	» Normal

Log in or register to post comments

Comment #9

wtrv CreditAttribution: wtrv at Wunder commented 30 March 2016 at 09:03

Hi Dave,

Thanks for clarifying.

Panels: 7.x-3.5
Ctools: 7.x-1.9

Log in or register to post comments

Comment #10

DYdave CreditAttribution: DYdave at DAVYIN Internet Solutions / 戴文信息科技有限公司 commented 30 March 2016 at 13:05

yeah.... @wtrv
sorry again about earlier.... we all have our moods and down times...

If you could potentially test again with corresponding dev versions for panels and ctools it would be awesome and greatly appreciated.

Having a feeling this might not necessarily be a block class-only problem

Thanks again very much for your involvement and help in module's development.

Log in or register to post comments

Comment #11

wtrv CreditAttribution: wtrv at Wunder commented 30 March 2016 at 13:28

Yeah.. no problem at all man.
I'm just learning the ropes as well :)

You're right in saying it's not really a block class problem.
Did some further testing an noticed that a custom pane was causing the issue. Because the $vars['pane'] object never got set.

The extra check on the variable I added in the patch should therefore not be necessary.
I don't think it's bad practise to have it there, but I'm leaving that up to you.

Thanks for your time and advice!

Log in or register to post comments

Comment #12

DYdave CreditAttribution: DYdave at DAVYIN Internet Solutions / 戴文信息科技有限公司 commented 30 March 2016 at 14:52

Splendid! :)

Any idea if there would be a related issue in panels or ctools?
If by any chance you were able to find a related ticket, it would be very helpful if you could please provide a link or even better, update this issue directly with the related one(s) from panels/ctools (see the "Related issues" field, in the "Issue summary & relationships" fieldset, right above the "Files" fieldset).

I agree with you, the extra check wouldn't do any harm and getting this patch committed at some point doesn't seem unlikely.
But I think things will keep on moving on the ctools/panels side, so I guess we will probably have to wait for a bit and see what happens there (at least until their next stable release).
I've been having compatibility issues with panels AND ctools in many block, Views or formatter related modules I've been maintaining.... so I've seen quite a lot of changes going on there.

Anyhow, glad there's no hard feelings, especially for a first impression :P.
We definitely value your help and involvement in the community.
Thanks again!
Cheers!