Module has various code styling issues which should be fixed to bring the code up to date with current Drupal standards.

CommentFileSizeAuthor
#2 code_standards_cleanup-2748759-2.patch13.52 KBaburke626
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

aburke626 created an issue. See original summary.

aburke626’s picture

aburke626
she/her
Primary language English
Location Harveys Lake, PA, US
CreditAttribution: aburke626 at Chromatic commented
FileSize
code_standards_cleanup-2748759-2.patch13.52 KB

Patch created to fix code standards issues.

aburke626’s picture

aburke626
she/her
Primary language English
Location Harveys Lake, PA, US
CreditAttribution: aburke626 at Chromatic commented
Status: Active » Needs review

  • dman committed 41db001 on 7.x-1.x authored by aburke626 
    Issue #2748759 by aburke626: Code Standards Cleanup
dman’s picture

dman CreditAttribution: dman as a volunteer commented
Status: Needs review » Fixed

Wow cool.
Thanks for the contribution! The code there certainly was built a number of years ago - before we had useful tools like pareview and PHPCS working.

I've put that in immediately - looks like it should all be totally safe!

Thanks heaps!

  • dman committed 842e9b3 on 7.x-1.x 
    Issue #2748759 : Follow-up additional code cleanups identified by PHP...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.