Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Hi, we start to port it to Drupal 8 on Github in https://github.com/ueberbit/bigmenu I will give a sign here when it is finished.
Comment | File | Size | Author |
---|---|---|---|
#11 | Screen Shot 2017-03-17 at 1.48.42 PM.png | 70.15 KB | dman |
#11 | Screen Shot 2017-03-17 at 1.44.52 PM.png | 74.05 KB | dman |
Comments
Comment #2
dman CreditAttribution: dman as a volunteer and at Sparks Interactive commentedInteresting!
I was sort of hoping that the problem this addresses would have gone away during the D8 changes, but I guess not.
Whatever happens, the AJAX layer (and probably everything else) will be a total rewrite, so I'd be happy to see it!
Thanks for the note.
Comment #3
lodius CreditAttribution: lodius commentedGreat news! Waiting with anticipation :D
Comment #4
patrickfwestonLikewise!
Comment #5
acbramley CreditAttribution: acbramley commentedHow's the progress on this one?
Comment #6
dman CreditAttribution: dman as a volunteer and at Sparks Interactive commentedI'd be happy to open a D8 branch here and share project commit rights with anyone who could be interested in having a go at this.
All we'd need is a start at a port that is *not broken* in D8 and has some underpinnings of basic functionality brought forward.
Hit an MVP (again - 'not broken' (and passes this years code standards) is good enough to start the D8 branch) and post something here and we would love to look at a merge some day.
- Me, I have been beaten into a quivering heap by D8 migrate and other D8 factors - not got swap space to even begin on this in the foreseeable future.
Comment #7
acbramley CreditAttribution: acbramley commented@dman awesome, I have commit access and I think we might need the module soon on our platform.
If I can get some time to investigate I'll have a look at the github module posted above and could use that as a starting point for an 8.x branch.
Comment #8
realityloopthis version is functional https://github.com/becw/bigmenu
Comment #9
acbramley CreditAttribution: acbramley commented@realityloop thanks! If that's in a state for a 8.x-1.x release I am happy to commit that to the project if the repo owner is happy to do so :)
Comment #10
dman CreditAttribution: dman as a volunteer and at Sparks Interactive commentedGood fun!
With high hopes, I thought I'd give it a go!
* I generated 500 menu items deep and wide with devel_generate
* visited Administration Structure Menus
* admin UI page was, as expected, big and structured and unwieldy
* Downloaded and enabled bigmenu from github OK
* ... the admin UI path seems to have changed /admin/structure/menu/manage/devel-cu to /admin/structure/menu/manage/devel-cu/bigmenu . This is understandable, but something to note.
* got ... a flat list of top-level menu items?
* We now have the ability to "Edit children items" - which does at least seem to slice things down from the top into slightly more manageable chunks.
* Editing one of these subtrees (or 'slice of a menu' as the title says)
* ... expands *everything* under it.
* And continues to present the "Edit children items" link for branches that are already expanded.
* Attempting to drag an item inside the 'slice' form looked like it worked client-side.
* Trying to Save it took me off that screen and back to the top :(.
* But on re-visiting, my change was at least retained!
OK, so there is - as I'd looked for - a not-broken work-in-progress here. Yay!
The AJAX stuff will be tricky, but I appreciate that this is the direction to go - when I did the original I also worked on getting a stand-alone copy of menu slices working in their own UI first, and ensuring that it was at least possible before moving on the embedding the AJAX version of that functionality.
Getting the tabledrag stuff emulated and working first is definitely a step along that path...
A visual review of the current code state reflects where things are at - a combination of working stuff and some left-overs from the upgrade still to be plucked out. The direction forward is pretty clear in the intent of what's there so far (though personally D8 'Controllers' are a new one on me :-)
Hell yeah - this deserves to be the foundation of the 8.x branch.
Let's merge and move forwards!
Code review note:
I spot that it includes a special case work-around for the contrib menu_admin_per_menu.module . That's fine, and understandable, but deserves to be signposted in either a comment or README.
Comment #11
dman CreditAttribution: dman as a volunteer and at Sparks Interactive commentedComment #12
Dennis Cohn CreditAttribution: Dennis Cohn at ezCompany commentedAny update on this?
Comment #13
jimkeller CreditAttribution: jimkeller commentedThis port seems to work fine for me, though it's pretty bare-bones.
One question: Is there a reason why "depth" is set explicitly to "5" in buildOverviewFormWithDepth in MenuSliceFormController? Leaving it at 1 seems to make more sense -- otherwise the usefulness of the module is degraded (imo) at lower levels of the menu.
Comment #14
jimkeller CreditAttribution: jimkeller commentedI've created a module to help with choosing big menu parent items from the node form and "add link" pages. It's a temporary solution to get by until more significant work can be done on the menu UI as a whole. However, this makes it reasonable for a user to choose a parent menu item even when the menu has many items:
Menu Parent Form UI Module:
https://github.com/jimkeller/menu_parent_form_ui
Comment #15
lorenzs CreditAttribution: lorenzs at Cegeka for VDAB commented@dman - Can we get this on drupal.org/project/bigmenu as a dev or alpha version?
Easier to track and motivate people to contribute IMO.
Comment #16
chandraraj CreditAttribution: chandraraj commentedI'm hugely benefited by the module's D7 version. Thanks @dman for the wonderful module.
Our site has been moved into Drupal 8 now and it has thousands of menu links. I have the issue of reordering the menu links. So I've downloaded and tested the D8 version of the module. It seems to be working well. Could you please release the D8 version of the module? Thanks in advance.
Comment #17
MrPaulDriver CreditAttribution: MrPaulDriver commentedThe are two github repos mentioned, which is the one to use? uberbit or becw?
Comment #18
zuernBernhard CreditAttribution: zuernBernhard at UEBERBIT GmbH commentedbecw is 20 commits ahead of ueberbit and should be the better starting point to continue the work on this module. perhaps it makes sense to bring it back to drupal.org
Comment #19
MrPaulDriver CreditAttribution: MrPaulDriver commentedThanks. It wasn't clear to me whether they had taken different directions.
Whilst I am sure there are some advantages to developing on github it does make the Drupal ecosystem very fragmented and that can not be such a good thing.
Comment #20
MrPaulDriver CreditAttribution: MrPaulDriver commentedHaving spent a few hours working with Bigmenu (becw), I would say that it is perfectly usable in it's current state, but I do think it would be better to have it hosted on drupal.org so that proper use with composer is possible.
A couple of suggestions for further improvement.
1.) Provide an 'Add link' for each menu slice level and assume that the new link should be added to the same slice
2.) Remove the redirection parameter from the save link action, so that the user is not kicked out of the slice or menu, leaving them to find their way back.
Of the second suggestion. I think a major issue with the Drupal menu UI, it that these redirection parameters are hard coded into all the links and actions. The redirection usually throws the user out and dumps them at admin/structure/menu . This is terribly frustrating and has a bad impact on productivity, when lots of work needs to be done on a menu.
Comment #21
xenophyle CreditAttribution: xenophyle commentedIt would be great to get this code on drupal.org!
Comment #22
zuernBernhard CreditAttribution: zuernBernhard at UEBERBIT GmbH commented@realityloop do you agree to upload your github-repo to drupal.org ?
https://github.com/becw/bigmenu
I am not a maintainer of this project. Who can help ?
Comment #23
acbramley CreditAttribution: acbramley commentedAlthough I'm not actively maintaining this project anymore I'm happy to commit a github repo as the 8.x-1.x branch so we can move development on to drupal.org.
Just give me the go ahead and I'll do it :)
Comment #24
xenophyle CreditAttribution: xenophyle commentedGo ahead! Is that good enough? :)
I take full responsibility for any damage to the internet moving development to drupal.org may cause.
Comment #25
acbramley CreditAttribution: acbramley commentedHaha, I need the all clear from the owner of https://github.com/becw/bigmenu, is that @realityloop (according to #22)?
Comment #26
realityloopthe becw repo isn't mine:
From the github profile:
Bec White
Development Operations Manager at Palantir.net.
http://twitter.com/becw
Comment #27
realityloopI've sent becw a tweet asking her to answer here about using her repo as a basis.
Comment #28
becw CreditAttribution: becw at Palantir.net commentedYes, you may absolutely use the work from @patrickfweston and I in that repo. If you can credit the Palantir.net organization, that'd be great!
Is there anything you need me to do to help out with the move?
Comment #29
acbramley CreditAttribution: acbramley at PreviousNext commentedPublished a new 8.x-1.x release and credited @becw and Palantir.net
https://www.drupal.org/project/bigmenu/releases/8.x-1.x-dev