Use `EntityTypeManagerInterface` instead of `EntityTypeManager`.
- Originally Found Here: Webprofiler module throws critical error as it decorates `EntityTypeManager`

Error Log:

NOTICE: PHP message: TypeError: Argument 1 passed to Drupal\bibcite_entity\Plugin\Derivative\MergeLocalTask::__construct() must be an instance of Drupal\Core\Entity\EntityTypeManager, instance of Drupal\webprofiler\Entity\EntityManagerWrapper given, called in /var/www/html/web/modules/contrib/bibcite/modules/bibcite_entity/src/Plugin/Derivative/MergeLocalTask.php on line 37 in /var/www/html/web/modules/contrib/bibcite/modules/bibcite_entity/src/Plugin/Derivative/MergeLocalTask.php on line 28 #0 /var/www/html/web/modules/contrib/bibcite/modules/bibcite_entity/src/Plugin/Derivative/MergeLocalTask.php(37): Drupal\bibcite_entity\Plugin\Derivative\MergeLocalTask->__construct(Object(Drupal\webprofiler\Entity\EntityManagerWrapper))
#1 /var/www/html/web/core/lib/Drupal/Core/Plugin/Discovery/ContainerDerivativeDiscoveryDecorator.php(25): Drupal\bibcite_entity\Plugin\Derivative\MergeLocalTask::create(Object(Drupal\Core\DependencyInjection\Container), 'bibcite_entity....')
#2 /var/www/html/web/core/lib/Drupal/Component/Plugin/Discovery/DerivativeDiscoveryDecorator.php(99): Drupal\Core\Plugin\Discovery\ContainerDerivativeDiscoveryDecorator->getDeriver('bibcite_entity....', Array)
#3 /var/www/html/web/core/lib/Drupal/Component/Plugin/Discovery/DerivativeDiscoveryDecorator.php(87): Drupal\Component\Plugin\Discovery\DerivativeDiscoveryDecorator->getDerivatives(Array)
#4 /var/www/html/web/core/lib/Drupal/Core/Plugin/DefaultPluginManager.php(284): Drupal\Component\Plugin\Discovery\DerivativeDiscoveryDecorator->getDefinitions()
#5 /var/www/html/web/core/lib/Drupal/Core/Plugin/DefaultPluginManager.php(175): Drupal\Core\Plugin\DefaultPluginManager->findDefinitions()
#6 /var/www/html/web/core/lib/Drupal/Core/Menu/LocalTaskManager.php(201): Drupal\Core\Plugin\DefaultPluginManager->getDefinitions()
#7 /var/www/html/web/core/lib/Drupal/Core/Menu/LocalTaskManager.php(226): Drupal\Core\Menu\LocalTaskManager->getDefinitions()
#8 /var/www/html/web/core/lib/Drupal/Core/Menu/LocalTaskManager.php(310): Drupal\Core\Menu\LocalTaskManager->getLocalTasksForRoute('system.admin')
#9 /var/www/html/web/core/lib/Drupal/Core/Menu/LocalTaskManager.php(378): Drupal\Core\Menu\LocalTaskManager->getTasksBuild('system.admin', Object(Drupal\Core\Cache\CacheableMetadata))
#10 /var/www/html/web/core/lib/Drupal/Core/Menu/Plugin/Block/LocalTasksBlock.php(95): Drupal\Core\Menu\LocalTaskManager->getLocalTasks('system.admin', 0)
#11 /var/www/html/web/core/modules/block/src/BlockViewBuilder.php(171): Drupal\Core\Menu\Plugin\Block\LocalTasksBlock->build()
#12 [internal function]: Drupal\block\BlockViewBuilder::preRender(Array)
#13 /var/www/html/web/core/lib/Drupal/Core/Security/DoTrustedCallbackTrait.php(100): call_user_func_array(Array, Array)
#14 /var/www/html/web/core/lib/Drupal/Core/Render/Renderer.php(781): Drupal\Core\Render\Renderer->doTrustedCallback(Array, Array, 'Render #pre_ren...', 'silenced_deprec...', 'Drupal\\Core\\Ren...')
#15 /var/www/html/web/core/lib/Drupal/Core/Render/Renderer.php(372): Drupal\Core\Render\Renderer->doCallback('#pre_render', Array, Array)
#16 /var/www/html/web/core/lib/Drupal/Core/Render/Renderer.php(444): Drupal\Core\Render\Renderer->doRender(Array)
#17 /var/www/html/web/core/lib/Drupal/Core/Render/Renderer.php(200): Drupal\Core\Render\Renderer->doRender(Array, false)
#18 /var/www/html/web/core/lib/Drupal/Core/Template/TwigExtension.php(501): Drupal\Core\Render\Renderer->render(Array)
#19 /var/www/html/vendor/twig/twig/src/Environment.php(497) : eval()'d code(96): Drupal\Core\Template\TwigExtension->escapeFilter(Object(Drupal\Core\Template\TwigEnvironment), Array, 'html', NULL, true)
#20 /var/www/html/vendor/twig/twig/src/Template.php(455): __TwigTemplate_4fe6cc54e5bbda3e0b1f9dec8793959721861b23a2367796ea4b486a14c9c9a9->doDisplay(Array, Array)
#21 /var/www/html/vendor/twig/twig/src/Template.php(422): Twig\Template->displayWithErrorHandling(Array, Array)
#22 /var/www/html/vendor/twig/twig/src/Template.php(434): Twig\Template->display(Array)
#23 /var/www/html/web/core/themes/engines/twig/twig.engine(64): Twig\Template->render(Array)
#24 /var/www/html/web/core/lib/Drupal/Core/Theme/ThemeManager.php(384): twig_render_template('core/themes/sev...', Array)
#25 /var/www/html/web/core/lib/Drupal/Core/Render/Renderer.php(431): Drupal\Core\Theme\ThemeManager->render('page', Array)
#26 /var/www/html/web/core/lib/Drupal/Core/Render/Renderer.php(200): Drupal\Core\Render\Renderer->doRender(Array, false)
#27 /var/www/html/web/core/lib/Drupal/Core/Template/TwigExtension.php(501): Drupal\Core\Render\Renderer->render(Array)
#28 /var/www/html/vendor/twig/twig/src/Environment.php(497) : eval()'d code(106): Drupal\Core\Template\TwigExtension->escapeFilter(Object(Drupal\Core\Template\TwigEnvironment), Array, 'html', NULL, true)
#29 /var/www/html/vendor/twig/twig/src/Template.php(455): __TwigTemplate_cadf35edaebefd061cff9987f9be6574fdd2495efff99779c03e11bdcaa921f4->doDisplay(Array, Array)
#30 /var/www/html/vendor/twig/twig/src/Template.php(422): Twig\Template->displayWithErrorHandling(Array, Array)
#31 /var/www/html/vendor/twig/twig/src/Template.php(434): Twig\Template->display(Array)
#32 /var/www/html/web/core/themes/engines/twig/twig.engine(64): Twig\Template->render(Array)
#33 /var/www/html/web/core/lib/Drupal/Core/Theme/ThemeManager.php(384): twig_render_template('profiles/contri...', Array)
#34 /var/www/html/web/core/lib/Drupal/Core/Render/Renderer.php(431): Drupal\Core\Theme\ThemeManager->render('html', Array)
#35 /var/www/html/web/core/lib/Drupal/Core/Render/Renderer.php(200): Drupal\Core\Render\Renderer->doRender(Array, false)
#36 /var/www/html/web/core/lib/Drupal/Core/Render/MainContent/HtmlRenderer.php(147): Drupal\Core\Render\Renderer->render(Array)
#37 /var/www/html/web/core/lib/Drupal/Core/Render/Renderer.php(573): Drupal\Core\Render\MainContent\HtmlRenderer->Drupal\Core\Render\MainContent\{closure}()
#38 /var/www/html/web/core/lib/Drupal/Core/Render/MainContent/HtmlRenderer.php(148): Drupal\Core\Render\Renderer->executeInRenderContext(Object(Drupal\Core\Render\RenderContext), Object(Closure))
#39 /var/www/html/web/core/lib/Drupal/Core/EventSubscriber/MainContentViewSubscriber.php(90): Drupal\Core\Render\MainContent\HtmlRenderer->renderResponse(Array, Object(Symfony\Component\HttpFoundation\Request), Object(Drupal\Core\Routing\CurrentRouteMatch))
#40 /var/www/html/web/modules/contrib/devel/webprofiler/src/EventDispatcher/TraceableEventDispatcher.php(79): Drupal\Core\EventSubscriber\MainContentViewSubscriber->onViewRenderArray(Object(Symfony\Component\HttpKernel\Event\GetResponseForControllerResultEvent), 'kernel.view', Object(Drupal\webprofiler\EventDispatcher\TraceableEventDispatcher))
#41 /var/www/html/vendor/symfony/http-kernel/HttpKernel.php(156): Drupal\webprofiler\EventDispatcher\TraceableEventDispatcher->dispatch(Object(Symfony\Component\HttpKernel\Event\GetResponseForControllerResultEvent), 'kernel.view')
#42 /var/www/html/vendor/symfony/http-kernel/HttpKernel.php(68): Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object(Symfony\Component\HttpFoundation\Request), 1)
#43 /var/www/html/web/core/lib/Drupal/Core/StackMiddleware/Session.php(57): Symfony\Component\HttpKernel\HttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#44 /var/www/html/web/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php(47): Drupal\Core\StackMiddleware\Session->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#45 /var/www/html/web/core/modules/page_cache/src/StackMiddleware/PageCache.php(106): Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#46 /var/www/html/web/core/modules/page_cache/src/StackMiddleware/PageCache.php(85): Drupal\page_cache\StackMiddleware\PageCache->pass(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#47 /var/www/html/web/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php(47): Drupal\page_cache\StackMiddleware\PageCache->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#48 /var/www/html/web/modules/contrib/devel/webprofiler/src/StackMiddleware/WebprofilerMiddleware.php(38): Drupal\Core\StackMiddleware\Revers...
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ash2303 created an issue. See original summary.

ash2303’s picture

Issue summary: View changes
ash2303’s picture

ash2303’s picture

Status: Needs work » Needs review
FiNeX’s picture

The patch looks good.

AardWolf’s picture

Status: Needs review » Reviewed & tested by the community
AardWolf’s picture

Status: Reviewed & tested by the community » Needs review
FileSize
963 bytes
1.37 KB

Patch update

  • hxdef committed bc37f83 on 8.x-1.x authored by AardWolf
    Issue #3221900 by AardWolf, ash2303: Improve Code Standard
    
hxdef’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.